Skip to content

Allow use of card component with role="article" #548

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

lukas-kasticky
Copy link

@lukas-kasticky lukas-kasticky commented May 25, 2024

Would be a welcome improvement. It's a valid ARIA role and makes things like <fieldset role="article"><!-- ... --></fieldset> possible. Any reasons not to do this?

@ginger-tek
Copy link

Would wrapping the element in an <article> do the same thing visually? Probably not semantic, so I get the reasoning for the role="article", though I propose role="card" instead

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants