Add versions to dist artifacts #288
Conversation
|
@picturepan2 Any comment on this MR? |
|
@victorparmar Why do you think this change is necessary? |
|
@picturepan2 As spectre matures, it would be good to offer built in versioning for users to manage updates. I have been using spectre.css in a few projects since 0.3.x and it is getting difficult for me to see which project is using which version. Of course I can always postfix the version myself but that is an extra step for me to remember and do. Other mature projects such as |
|
@picturepan2 I'm sorry to be a pain in the ass but I have a few projects that are waiting to be updated and it would be great to have versioning built in. Otherwise I will need to make a custom automated solution to generate my own builds. It would be great if you could let me know if you consider adding this feature or don't plan on it at all. Thanks, |
|
Bootstrap versions by adding commented code to the top of their dist. They don't version their filenames Would this work? |
|
Yes. I can add this after the vacation.
Yan Zhu
…________________________________
From: Developer <notifications@github.com>
Sent: Wednesday, October 4, 2017 9:32:48 AM
To: picturepan2/spectre
Cc: Yan Zhu; Mention
Subject: Re: [picturepan2/spectre] Add versions to dist artifacts (#288)
Bootstrap versions by adding commented code to the top of their dist
/*!
* Bootstrap v4.0.0-beta (https://getbootstrap.com)
* Copyright 2011-2017 The Bootstrap Authors
* Copyright 2011-2017 Twitter, Inc.
* Licensed under MIT (https://github.com/twbs/bootstrap/blob/master/LICENSE)
Would this work?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#288 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAHtsXzOFHjjgCoXbWcJEhgYXEldEThLks5souA-gaJpZM4Pfylo>.
|
|
@Geczy Version number is added to CSS files in v0.4.4. |
This PR is to have the dist artifacts versioned to manage upgrades. Closes #289