Fix IndexError when abbrv is longer than original; Close #12 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, there is a mismatch between abbreviation and original, where a dot is added to an unabbreviated word, e.g., "Control". If this occurs, the dot is removed and the abbreviation is reduced to the length of the original word.
Fix the wrong classification of single letter part names, if the single letter is also a stopword.
|
Fine by me, although having an actual journal with "review**.**" is a bit surprising. For example, Phys. Rev. A, that you included in your test, do not include a dot at the end of its name. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, there is a mismatch between abbreviation and original, where a dot is added to an unabbreviated word, e.g., "Control". If this occurs, the dot is removed and the abbreviation is reduced to the length of the original word.
This closes #12