Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactor: bundle, typescript, formatting, node20 #11

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

ndelangen
Copy link
Contributor

  • migrate to typescript
  • use pnpm for installing node_modules
  • add prettier for formatting
  • add a github action for testing
  • move code into root of repo

@ndelangen
Copy link
Contributor Author

Would you be open to this PR?

I can revert the renames.

@pietrobolcato
Copy link
Owner

totally, that's awesome! thanks for the great work and taking the time 🙏
as we're already implementing some testing in gha, what about making it a unit test that can be run locally too, and the workflow could become a very simple CI that ensures always the keys etc are read correctly?

@rodrigo-oliveira-silva
Copy link

Hi guys,

Is there an estimate for this pull request to be completed?

@dorz-saymine
Copy link

Hi,
Any update?

@ndelangen
Copy link
Contributor Author

You might want to use my fork till I get around to re-doing this PR:
https://github.com/ndelangen/action-read-yaml

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants