Binance syminfo and mintick #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodboy
commented
May 25, 2021
| async with ctx.open_stream() as stream: | ||
|
|
||
| async for pattern in stream: | ||
| # results = await client.symbol_info(sym=pattern.upper()) |
There was a problem hiding this comment.
Yeah turns out they don't have a "search" in the API they offer, you have to have the exact symbol.
Collecting the whole cache at client startup is reasonably fast anyway (and we do it async with the other backends), so all gud i think.
guilledk
approved these changes
May 25, 2021
|
Ahh gotta push up a |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some stuff we missed in
binancebackend..symbol_info()@guilledk you should rebase your #182 off this 😎