Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: engines node@>=18 #233

Merged
merged 1 commit into from
Jul 26, 2024
Merged

fix: engines node@>=18 #233

merged 1 commit into from
Jul 26, 2024

Conversation

wesleytodd
Copy link
Member

cc @ctcpip

@ctcpip
Copy link
Member

ctcpip commented Jul 26, 2024

I notice 0.18 is still latest in npm. that expected?

@wesleytodd
Copy link
Member Author

Yes, I did that on purpose because we need to do some integration validation across all the express repos before I am comfortable with new installs getting this. I did link locally but the test were flaky (see the edit history of the PR to express lol) and so I was worried maybe it was something up with this, but then all the tests passed in CI and locally it seemed to have been a fluke (why I could not find) but I didn't want to go all in since this is an easy way to "soft release" the new major since I think it is actually solid.

@wesleytodd wesleytodd merged commit 672e5c3 into master Jul 26, 2024
4 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants