Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adding new enum to detect the type of a mailbox #226

Closed
wants to merge 2 commits into from

Conversation

TornaxO7
Copy link
Contributor

This should fix #172

@TornaxO7
Copy link
Contributor Author

I'm a little bit unsure, if MboxType suits here. Probably a MboxAttribute enum might be better but this would mean that we have to map the enum values of NameAttribute as well, at least, if we'd map the NameAttribute to a MboxAttribue enum, then we could always access the mbox easily with our new-type variant. What do you think about that @soywod ?

@soywod soywod changed the base branch from master to development October 14, 2021 10:53
@soywod
Copy link
Member

soywod commented Oct 14, 2021

I'm afraid you started to develop this from master, so you are not aware about new stuff in development. I changed the target branch and you seem to have conflicts. I refactored well the Mbox (with comments + tests), maybe this refactor will help you in what you wanted to achieve there? It sounds great to me what you did anyway, thanks to take this point it's a tough one

@soywod
Copy link
Member

soywod commented Oct 14, 2021

Oh wait, this means we will have one extra call at every command 😕. The user does not have to configure anything at the cost of a bigger response delay. But what if a user defines a mailbox named "MySent" with attributes "Custom(MySent)" as his sending folder? This case would not work. Maybe we should let users configure their mailboxes name. We could set up defaults in case they are not set up (as it works right now on master), it should match 80% of users.

@soywod
Copy link
Member

soywod commented Oct 14, 2021

Sth like folder-archive = "Archive", folder-drafts = "Drafts", folder-junk = "Junk", folder-sent = "Sent" and folder-trash = "Trash" in the configuration (global and specific by accounts).

@TornaxO7
Copy link
Contributor Author

I'm afraid you started to develop this from master, so you are not aware about new stuff in development.

Ooof... yes, you're right. I forgot to do that... I'll close this PR and restart it again.

Sth like folder-archive = "Archive", folder-drafts = "Drafts", folder-junk = "Junk", folder-sent = "Sent" and folder-trash = "Trash" in the configuration (global and specific by accounts).

Yeah, sounds good to me

@soywod
Copy link
Member

soywod commented Oct 23, 2021

I switched the default branch to development so that future PRs will point automatically to development instead of master.

@TornaxO7
Copy link
Contributor Author

Since it seems like that the user has to define in their config which mailbox should be used for what, I'm going to close this PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not append message to Sent if the sending folder is not named Sent
2 participants