-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove 300ms delay before logoless boot #24
Conversation
This PR eliminates all pre-boot screen noise for games with Findings: Removing the delay mostly resolves it on hardware - though there's still a nigh-imperceptible one-frame flash of randomness.. I'm a little confused: Hoisting the Moving the
The missing piece was to flip the screen buffer in the |
Pulling back to draft; I think what's going on is that the screen buffers aren't getting initialized. |
Ok. Clearing the screen and flipping twice did it, but only after making it wait for the flips. |
I keep pulling back to draft, but it occurs to me there might be An Easier Way™. |
Final one. Incidentally, the program used for testing is just:
|
@@ -20,11 +20,11 @@ namespace picosystem { | |||
|
|||
#ifndef DYNAMIC_BUFFER | |||
#ifdef PIXEL_DOUBLE | |||
color_t _fb[120 * 120]; | |||
color_t _fb[120 * 120] = { }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An empty initializer initializes to 0
's. No initializer leaves it randomized.
while (_is_flipping()); | ||
// wait for the screen to update | ||
_wait_vsync(); | ||
_wait_vsync(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one leaves The Flash™, two leaves it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it does! We'll probably dig deeper into this. Thank you!
Thank you! |
Tested on hardware, removing the delay clears up the boot noise problem in issue #9