Support list or string for default_command config

[alexdavid]

Fixes #348

default_command can now be either a string (as before):

default_command = flush

or a list which is passed directly to argv:

default_command = --color, never, list, --startable

Let me know if you want me to add any documentation around this, and if so, where

[alexdavid]

Failing tests seem to be unrelated to my change. Looks like master is failing on its own: #385

[WhyNotHugo]

Hmm... True, master seems to have broken. I'm guessing some upstream lib recently changed. Lemme look into that. 🤔

[WhyNotHugo]

Hi again. Thanks for contributing! :)

I've fixed master via #387, so you can merge/rebase and CI should work. Looks like a recent change in click 7.1 broke tests.

This is a very welcome improvement, so thanks for addressing it.

Can you please update the docs too? Also, feel free to add yourself to AUTHORS. Thanks!

[alexdavid]

Rebased & test are working now. Thanks!

For documentation, I'm not seeing any existing documentation for default_command. Would you like me to add a section to docs/source/configure.rst?

[WhyNotHugo]

Documentation is rendered in the Configuring page, but is actually extracted from the file that defines these settings. That would be the right place for it.

[alexdavid]

I got super wrapped up with other things for the past few weeks. I updated the documentation, but wasn't sure how to denote that the option could be a string or list. I think it's fair to mark it as a list since the config parsing library coerces a list of size one into a string anyway:

default_command = list, --reverse

becomes a list
vs

default_command = list

is a string.

What are your thoughts?

[alexdavid]

Ugh github closed my PR for resetting my branch back to master trying to figure out why the tests are failing again

[WhyNotHugo]

I think documenting it as a list is probably best, since that's the most flexible way of using it. Don't worry too much if the ability to use a string isn't too obviously reflected.

[strk]

It's a pity to see this PR stuck, I was considering using it to get a default list sorting ( see GH-558 )

@alexdavid are you planning to get back to this or should I consider re-filing it under my name ?

[WhyNotHugo]

Things like default_command = "list --sort due --no-reverse" work on the latest version.

Arguments are split on space, which I guess shouldn't be an issue for real-life usages?

[strk]

I'm running todoman, version 4.1.0, from repository of Debian 12 - what version is latest version ? What's the recommended way to upgrade ? Should this PR be closed then ?

[strk]

On Thu, Jul 25, 2024 at 02:17:09AM -0700, Hugo wrote: Things like `default_command = "list --sort due --no-reverse"` work on the latest version. Arguments are split on space, which I guess shouldn't be an issue for real-life usages?

Indeed it works for me. I'd close this PR

…

--strk;

[WhyNotHugo]

Latest is v4.4.0, from Oct 2023. You can ping the Debian devs package maintainer for an update; there have been no breaking changes since v4.0.0.

If that leads nowhere, try using pipx.