make medium use a label as identifier #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sherzberg I actually like this change. Sorry for not merging it sooner. |
|
@sherzberg i'll try to update it and get it merged but if you could do me a favor and rebase your branch to get it updated so that I can merge it through GitHub it might make things faster. Thanks. |
this commit uses the backends label from NOTIFICATION_BACKENDS setting for easier to rearrange backends Conflicts: notification/backends/__init__.py pinax/notifications/models.py
sherzberg
force-pushed
the
medium_id-is-label
branch
from
b832c3f to
057a311
Compare
|
@paltman cool! i rebased and had to fix a few conflicts. tests seem to pass locally on python 2.7 and django 1.7-1.8. I dont have python 3 setup on my home machine, so just waiting to see if the the travis build works out ok. |
|
@paltman Can this be merged? |
|
@sherzberg i tested this PR with python3 and it works.. hope it gets merged sometime |
psychok7
referenced
this pull request
in Ubiwhere/pinax-notifications
Nov 29, 2016
|
@paltman @ossanna16 can this be merged? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21 this commit uses the backends label from NOTIFICATION_BACKENDS setting
for easier to rearrange backends
for upgrades, you may have to write a custom alter statement to turn integers into varchars and then change the labels in your NOTIFICATION_BACKENDS to the string equivalent of the order