Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: remove deprecated heartbeat code (#2121) #2151

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2121

What problem does this PR solve?

as title

What is changed and how it works?

Since "heartbeat" has been deprecated for a long time in DM 2.0 and we already have another way of calculating syncer's lag, I am trying to remove the unused code from the DM codebase.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Sep 18, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • glorv

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/XXL status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0 labels Sep 18, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 One reviewer already commented LGTM label Sep 18, 2021
@lance6716
Copy link
Collaborator

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Sep 18, 2021
@Ehco1996
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 48343dc

@ti-chi-bot ti-chi-bot merged commit 41f173e into pingcap:release-2.0 Sep 18, 2021
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
size/XXL status/can-merge status/LGT2 Two reviewers already commented LGTM, ready for merge status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick-for-release-2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants