-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
include compatibility notice for tidb_remove_orderby_in_subquery #20684
base: master
Are you sure you want to change the base?
include compatibility notice for tidb_remove_orderby_in_subquery #20684
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request includes a compatibility notice for the tidb_remove_orderby_in_subquery
system variable. The change involves updating the release notes to reflect a change in the default value of this variable. The pull request description is comprehensive, covering the necessary details and affected versions.
Merge Readiness
The pull request appears to be ready for merging, as it primarily involves documentation updates and includes sufficient information for users to understand the change. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Warning You have reached your daily quota limit. As a reminder, free tier users are limited to 5 requests per day. Please wait up to 24 hours and I will start processing your requests again! |
[LGTM Timeline notifier]Timeline:
|
What is changed, added or deleted? (Required)
Please refer to pingcap/docs-cn#20139
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?