Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tidb-scheduler now supports kubescheduler.config.k8s.io/v1 in tidb-operator helm charts #6089

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

makocchi-git
Copy link
Contributor

@makocchi-git makocchi-git commented Feb 20, 2025

What problem does this PR solve?

  • tidb-scheduler crashes when deployed on Kubernetes clusters with version 1.28 or higher because kubescheduler.config.k8s.io/v1beta2 was removed from 1.28.
$ kubectl version
Client Version: v1.31.2
Kustomize Version: v5.4.2
Server Version: v1.31.4

$ kubectl get pod
NAME                                      READY   STATUS             RESTARTS        AGE
tidb-controller-manager-8c464f99d-h6phh   1/1     Running            0               15m
tidb-scheduler-f8b4568f8-rjbzv            1/2     CrashLoopBackOff   7 (4m22s ago)   15m

$ kubectl logs tidb-scheduler-f8b4568f8-rjbzv -c kube-scheduler
...
I0220 09:45:24.146211       1 serving.go:386] Generated self-signed cert in-memory
E0220 09:45:24.146505       1 run.go:72] "command failed" err="no kind \"KubeSchedulerConfiguration\" is registered for version \"kubescheduler.config.k8s.io/v1beta2\" in scheme \"pkg/scheduler/apis/config/scheme/scheme.go:29\""
  • Use Capabilities.KubeVersion.Version instead of Capabilities.KubeVersion.GitVersion
    • Capabilities.KubeVersion.GitVersion was already removed in helm docs.

What is changed and how does it work?

Use kubescheduler.config.k8s.io/v1 in tidb-operator helm charts template when Kubernetes version 1.25 or higher.
(kubescheduler.config.k8s.io/v1 was GA at 1.25)

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

tidb-scheduler now supports kubescheduler.config.k8s.io/v1 in tidb-operator helm charts

Copy link
Contributor

ti-chi-bot bot commented Feb 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign srstack for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/M and removed size/S labels Feb 20, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.80%. Comparing base (a16b2e8) to head (bf28954).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6089      +/-   ##
==========================================
- Coverage   57.19%   55.80%   -1.40%     
==========================================
  Files         259      266       +7     
  Lines       33233    46209   +12976     
==========================================
+ Hits        19008    25787    +6779     
- Misses      12291    18414    +6123     
- Partials     1934     2008      +74     
Flag Coverage Δ
unittest 55.80% <ø> (-1.40%) ⬇️

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants