Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

util: fix codec for negative zero(#57343) | tidb-test=pr/2429 #57453

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57343

What problem does this PR solve?

Issue Number: close #41878
Negative zero is incorrectly converted to zero after being encoded and then decoded.

Problem Summary:
Correctly handle the encoding issue of negative zero.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
tidb> CREATE TABLE t1 (c0 decimal(10,0));
Query OK, 0 rows affected (0.11 sec)

tidb> INSERT INTO t1 VALUES (0);
Query OK, 1 row affected (0.02 sec)

tidb> SELECT c0 FROM t1 WHERE CAST(ATAN2(((t1.c0) IS NULL), (- (''))) AS TIME); -- actual: {}, expected: {0}
+------+
| c0   |
+------+
|    0 |
+------+
1 row in set (0.00 sec)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 18, 2024
@wshwsh12 wshwsh12 changed the title util: fix codec for negative zero | tidb-test=pr/2427 (#57343) util: fix codec for negative zero(#57343) | tidb-test=pr/2429 Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@a9d32f0). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.5     #57453   +/-   ##
================================================
  Coverage               ?   56.9879%           
================================================
  Files                  ?       1770           
  Lines                  ?     626375           
  Branches               ?          0           
================================================
  Hits                   ?     356958           
  Misses                 ?     245346           
  Partials               ?      24071           
Flag Coverage Δ
integration 37.2510% <100.0000%> (?)
unit 72.6570% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 52.4309% <0.0000%> (?)
---- 🚨 Try these New Features:

@wshwsh12
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 19, 2024
Copy link

ti-chi-bot bot commented Nov 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 19, 2024
Copy link

ti-chi-bot bot commented Nov 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 03:27:56.842828654 +0000 UTC m=+931639.033697650: ☑️ agreed by XuHuaiyu.
  • 2024-11-19 03:29:21.456246341 +0000 UTC m=+931723.647115338: ☑️ agreed by wshwsh12.

@ti-chi-bot ti-chi-bot bot merged commit 2cb550a into pingcap:release-8.5 Nov 19, 2024
18 checks passed
wshwsh12 added a commit to wshwsh12/tidb that referenced this pull request Nov 19, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants