-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
util: fix codec for negative zero(#57343) | tidb-test=pr/2429 #57453
util: fix codec for negative zero(#57343) | tidb-test=pr/2429 #57453
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57453 +/- ##
================================================
Coverage ? 56.9879%
================================================
Files ? 1770
Lines ? 626375
Branches ? 0
================================================
Hits ? 356958
Misses ? 245346
Partials ? 24071
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wshwsh12, XuHuaiyu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…)" This reverts commit 2cb550a.
This is an automated cherry-pick of #57343
What problem does this PR solve?
Issue Number: close #41878
Negative zero is incorrectly converted to zero after being encoded and then decoded.
Problem Summary:
Correctly handle the encoding issue of negative zero.
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.