-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
*: support cancel query like 'select * from information_schema.tables' (#57766) #57806
*: support cancel query like 'select * from information_schema.tables' (#57766) #57806
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57806 +/- ##
================================================
Coverage ? 57.4921%
================================================
Files ? 1770
Lines ? 631806
Branches ? 0
================================================
Hits ? 363239
Misses ? 244558
Partials ? 24009
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Rustin170506, tiancaiamao, wjhuang2016 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #57766
What problem does this PR solve?
Issue Number: close #57749
Problem Summary:
What changed and how does it work?
Check ctx cancel in the loop.
ListTables
might be slow when there are too many tables, add a ctx to it to support cancel.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.