-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
planner: Limit fine grained shuffle usage for mpp join operators to ensure shuffle keys are the same with actual join keys (#59884) #59914
base: release-8.1
Are you sure you want to change the base?
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@yibin87 This PR has conflicts, I have hold it. |
Signed-off-by: yibin87 <huyibin@pingcap.com>
Signed-off-by: yibin87 <huyibin@pingcap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.1 #59914 +/- ##
================================================
Coverage ? 71.2206%
================================================
Files ? 1468
Lines ? 424037
Branches ? 0
================================================
Hits ? 302002
Misses ? 101490
Partials ? 20545
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: guo-shaoge, windtalker The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #59884
What problem does this PR solve?
Issue Number: close #59877
Problem Summary:
Problem described here
What changed and how does it work?
This PR limit the fined grained shuffle usage to situations that shuffle keys are the same with actual join keys. In this way the pre-calculated hash codes will always be valid.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.