-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
planner: update AnalyzeTableStmt to use NonPartitionTableID for non-partitioned tables #59937
Conversation
…artitioned tables Signed-off-by: Rustin170506 <techregister@pm.me>
Signed-off-by: Rustin170506 <techregister@pm.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates the AnalyzeTableStmt implementation to use the new constant statistics.NonPartitionTableID for non-partitioned tables, ensuring consistency across analyze tasks. Key changes include:
- Replacing the hardcoded value -1 with statistics.NonPartitionTableID in various analyze task functions.
- Removing the now unnecessary UpdateStatsVersion function from the statistics package.
- Updating the StatsReadWriter interface to reflect the removal of the deprecated method.
Reviewed Changes
File | Description |
---|---|
pkg/planner/core/planbuilder.go | Replaced occurrences of -1 with statistics.NonPartitionTableID. |
pkg/statistics/handle/storage/stats_read_writer.go | Removed the obsolete UpdateStatsVersion function. |
pkg/statistics/handle/types/interfaces.go | Updated interface by removing the UpdateStatsVersion method. |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59937 +/- ##
================================================
+ Coverage 72.9269% 73.6106% +0.6837%
================================================
Files 1700 1731 +31
Lines 469718 478754 +9036
================================================
+ Hits 342551 352414 +9863
+ Misses 106052 104450 -1602
- Partials 21115 21890 +775
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close None
Problem Summary:
What changed and how does it work?
statistics.NonPartitionTableID
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.