Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ci: udpate OWNERS_ALIASES file #11571

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Sep 6, 2024

transfer easonn7 to BenMeadowcroft

Signed-off-by: wuhuizuo wuhuizuo@126.com

What problem does this PR solve?

Issue Number: ref #10895

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

transfer `easonn7` to `BenMeadowcroft`

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Sep 6, 2024

/cc @yudongusa @benmeadowcroft

Copy link
Contributor

ti-chi-bot bot commented Sep 6, 2024

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: yudongusa, benmeadowcroft.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @yudongusa @benmeadowcroft

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Sep 6, 2024

/cc @Benjamin2037 @flowbehappy

Copy link
Contributor

ti-chi-bot bot commented Sep 6, 2024

@flowbehappy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, flowbehappy, hicqu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-06 10:37:13.02310752 +0000 UTC m=+7102.763531465: ☑️ agreed by Benjamin2037.
  • 2024-09-09 04:01:50.206663441 +0000 UTC m=+242579.947087381: ☑️ agreed by hicqu.

@ti-chi-bot ti-chi-bot bot merged commit 4ccbc94 into pingcap:master Sep 9, 2024
10 checks passed
wk989898 pushed a commit to wk989898/tiflow that referenced this pull request Sep 24, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants