-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
dm: add compactor for syncer #3162
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@Ehco1996 @lance6716 PTAL fefa97c |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/hold |
/run-all-tests |
/run-all-tests |
@glorv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
/unhold |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: bd151d1
|
Codecov Report
@@ Coverage Diff @@
## master #3162 +/- ##
================================================
- Coverage 57.2251% 56.9109% -0.3142%
================================================
Files 163 210 +47
Lines 19453 22667 +3214
================================================
+ Hits 11132 12900 +1768
- Misses 7261 8451 +1190
- Partials 1060 1316 +256 |
What problem does this PR solve?
add compactor to compact dml
What is changed and how it works?
Check List
Tests