Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

manager: manage capture and replay jobs #666

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #665

Problem Summary:
Manage capture and replay jobs.

What is changed and how it works:

  • Add a JobManager to manage and show the jobs. It's the interface for HTTP API
  • Refactor Replay to make it reusable for replaying

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox September 11, 2024 11:52
@ti-chi-bot ti-chi-bot bot added the size/XL label Sep 11, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 82.60870% with 24 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@aa61869). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/sqlreplay/replay/replay.go 42.85% 10 Missing and 2 partials ⚠️
pkg/sqlreplay/manager/manager.go 90.32% 6 Missing and 3 partials ⚠️
pkg/sqlreplay/manager/job.go 82.35% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #666   +/-   ##
=======================================
  Coverage        ?   69.63%           
=======================================
  Files           ?       97           
  Lines           ?     9296           
  Branches        ?        0           
=======================================
  Hits            ?     6473           
  Misses          ?     2351           
  Partials        ?      472           
Flag Coverage Δ
unit 69.63% <82.60%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

ti-chi-bot bot commented Sep 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Sep 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-11 14:19:15.914141862 +0000 UTC m=+452425.654565817: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 61d1509 into pingcap:main Sep 11, 2024
5 checks passed
@djshow832 djshow832 deleted the manage branch September 12, 2024 00:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage capture and replay jobs
3 participants