playground: print version when filling binpath #2334

HuSharp · 2023-12-19T02:06:18Z

What problem does this PR solve?

When filling in the binpath, it isbetter to print out the instance using binpath

What is changed and how it works?

before

$ tiup playground v7.5.0 --pd.binpath /Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:v7.5.0
Start tikv instance:v7.5.0
Start tidb instance:v7.5.0

after

$ ./tiup-playground v8.1.0 --pd.mode ms --pd 1 --tiflash 0 --scheduling 3 --tso 2 --pd.binpath /Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:/Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:/Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:/Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:/Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:/Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start pd instance:/Users/pingcap/CS/PingCAP/pd/bin/pd-server
Start tikv instance:v8.1.0
Start tidb instance:v8.1.0

Check List

Tests

Manual test (add detailed scripts or steps below)

Release notes:

print version when filling binpath

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp · 2023-12-19T02:06:28Z

cc @lhy1024

codecov-commenter · 2023-12-19T02:07:42Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.91%. Comparing base (342c767) to head (b13c405).
Report is 1 commits behind head on master.

❗ Current head b13c405 differs from pull request most recent head af5f9ec

Please upload reports for the commit af5f9ec to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2334      +/-   ##
==========================================
- Coverage   55.22%   50.91%   -4.32%     
==========================================
  Files         334      328       -6     
  Lines       35982    34984     -998     
==========================================
- Hits        19871    17810    -2061     
- Misses      13726    14853    +1127     
+ Partials     2385     2321      -64

Flag	Coverage Δ
tiup	`33.59% <ø> (-0.23%)`	⬇️
unittest	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ti-chi-bot · 2023-12-19T04:07:56Z

@lhy1024: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

breezewish · 2023-12-19T05:47:45Z

components/playground/instance/instance.go

@@ -70,6 +70,8 @@ type Instance interface {
 	// Wait Should only call this if the instance is started successfully.
 	// The implementation should be safe to call Wait multi times.
 	Wait() error
+	// BinPathCheck return the bin path to check component version.
+	BinPathCheck(utils.Version) string


How about simply return the bin path (and call it BinPath)? The current API mixes two different things together, which is confusing and not useful for other purposes.

How about advancing the PrepareBinary function?

Signed-off-by: husharp <jinhao.hu@pingcap.com>

nolouch

lgtm

ti-chi-bot · 2024-01-04T10:28:17Z

@nolouch: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: husharp <jinhao.hu@pingcap.com>

Signed-off-by: husharp <ihusharp@gmail.com>

HuSharp · 2024-07-15T03:24:43Z

PTAL, thx! @xhebox

Signed-off-by: husharp <ihusharp@gmail.com>

ti-chi-bot · 2024-07-15T04:20:32Z

[LGTM Timeline notifier]

Timeline:

2024-07-15 04:20:32.73540351 +0000 UTC m=+241254.726344973: ☑️ agreed by xhebox.

xhebox · 2024-07-15T04:34:20Z

/approve

ti-chi-bot · 2024-07-15T04:34:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [xhebox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

print version

34bcaf1

Signed-off-by: husharp <jinhao.hu@pingcap.com>

ti-chi-bot bot requested a review from breezewish December 19, 2023 02:06

ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 19, 2023

HuSharp changed the title ~~playground: print version~~ playground: print version when filling binpath Dec 19, 2023

lhy1024 approved these changes Dec 19, 2023

View reviewed changes

breezewish reviewed Dec 19, 2023

View reviewed changes

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 19, 2023

advance prepare

c452cda

Signed-off-by: husharp <jinhao.hu@pingcap.com>

HuSharp force-pushed the print_instance_ver branch from 04feb27 to c452cda Compare December 19, 2023 06:44

remove version

d780444

Signed-off-by: husharp <jinhao.hu@pingcap.com>

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2023

nolouch approved these changes Jan 4, 2024

View reviewed changes

merge master

dc6a222

Signed-off-by: husharp <jinhao.hu@pingcap.com>

ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2024

HuSharp added 2 commits January 8, 2024 15:50

merge master

3cb74e7

Signed-off-by: husharp <jinhao.hu@pingcap.com>

merge master

b9c705d

Signed-off-by: husharp <jinhao.hu@pingcap.com>

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2024

merge master

85d1ec0

Signed-off-by: husharp <ihusharp@gmail.com>

ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2024

HuSharp force-pushed the print_instance_ver branch from cb003e9 to 115f047 Compare July 15, 2024 03:22

ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 15, 2024

remove version

36e9b5f

Signed-off-by: husharp <ihusharp@gmail.com>

HuSharp force-pushed the print_instance_ver branch from 115f047 to 36e9b5f Compare July 15, 2024 03:24

move print

af5f9ec

Signed-off-by: husharp <ihusharp@gmail.com>

xhebox approved these changes Jul 15, 2024

View reviewed changes

ti-chi-bot bot added the lgtm label Jul 15, 2024

ti-chi-bot bot added the approved label Jul 15, 2024

ti-chi-bot bot merged commit 654b087 into pingcap:master Jul 15, 2024
7 checks passed

HuSharp deleted the print_instance_ver branch July 15, 2024 04:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

playground: print version when filling binpath #2334

playground: print version when filling binpath #2334

HuSharp commented Dec 19, 2023 •

edited

Loading

HuSharp commented Dec 19, 2023

codecov-commenter commented Dec 19, 2023 •

edited

Loading

ti-chi-bot bot commented Dec 19, 2023

breezewish Dec 19, 2023

HuSharp Dec 19, 2023

nolouch left a comment

ti-chi-bot bot commented Jan 4, 2024

HuSharp commented Jul 15, 2024

ti-chi-bot bot commented Jul 15, 2024

xhebox commented Jul 15, 2024

ti-chi-bot bot commented Jul 15, 2024

playground: print version when filling binpath #2334

playground: print version when filling binpath #2334

Conversation

HuSharp commented Dec 19, 2023 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

HuSharp commented Dec 19, 2023

codecov-commenter commented Dec 19, 2023 • edited Loading

Codecov Report

ti-chi-bot bot commented Dec 19, 2023

breezewish Dec 19, 2023

Choose a reason for hiding this comment

HuSharp Dec 19, 2023

Choose a reason for hiding this comment

nolouch left a comment

Choose a reason for hiding this comment

ti-chi-bot bot commented Jan 4, 2024

HuSharp commented Jul 15, 2024

ti-chi-bot bot commented Jul 15, 2024

[LGTM Timeline notifier]

xhebox commented Jul 15, 2024

ti-chi-bot bot commented Jul 15, 2024

HuSharp commented Dec 19, 2023 •

edited

Loading

codecov-commenter commented Dec 19, 2023 •

edited

Loading