-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
cluster: fix that scaled nodes don't respect component_versions
#2451
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2451 +/- ##
==========================================
- Coverage 55.19% 48.11% -7.08%
==========================================
Files 334 333 -1
Lines 35981 36049 +68
==========================================
- Hits 19859 17343 -2516
- Misses 13742 16381 +2639
+ Partials 2380 2325 -55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What problem does this PR solve?
close #2450
When scale-out a component, the version of the scaled node doesn't respect the version specified in the
component_versions
of the original spec.What is changed and how it works?
When creating the new topology, copy
ComponentVersions
tonewPart
, which is used when deploying new instances. Tests show that the component_versions would be merged correctly when parsing the scale-out topology.Check List
Tests
Follow the steps in the issue and check the version of the scale node.
Code changes
Side effects
Related changes
Release notes: