Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dropping readable-stream polyfill #541

Closed
benmccann opened this issue Nov 7, 2024 · 2 comments · Fixed by #542
Closed

Dropping readable-stream polyfill #541

benmccann opened this issue Nov 7, 2024 · 2 comments · Fixed by #542

Comments

@benmccann
Copy link
Contributor

It looks like the CI tests Node 18.17+, so I guess that might be the minimum version supported by this library. Once that's raised to Node 18.19+ it would be nice to drop the readable-stream dependency. I'm guessing that would be a change in supported Node versions and would be considered a breaking change, so might have to wait until the next major.

@kibertoad
Copy link
Contributor

Node 18 goes EOL on 2025-04-30, so personally I don't see a big problem with bumping minimum version to Node 20 in the nearby future (in a semver major, of course).
fastify has already done that.

as a bonus, node:test could be used instead of tap then

@mcollina
Copy link
Member

mcollina commented Nov 8, 2024

I'm +1 on removing, send a PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants