chore: replace readable-stream with built-in stream #542
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Nov 8, 2024
.github/workflows/ci.yml
Outdated
| @@ -40,7 +40,7 @@ jobs: | |||
| contents: read | |||
| strategy: | |||
| matrix: | |||
| node-version: [18.17, 20, 22] | |||
| node-version: [18.19, 20, 22] | |||
There was a problem hiding this comment.
isn't that technically a semver major? I'd rather use the opportunity to drop node 18 from the list altogether
|
@kibertoad we just bumped the major, I don't think we need another bump. |
|
cc @jsumners |
|
We probably should have done it then, but I'm really not opposed to version churn on this module. I consider this module non-essential, and as such don't think it matters too much how often it is released. |
alexandresoro
pushed a commit
to alexandresoro/ouca
that referenced
this pull request
Nov 26, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pino-pretty](https://github.com/pinojs/pino-pretty) | dependencies | major | [`11.3.0` -> `13.0.0`](https://renovatebot.com/diffs/npm/pino-pretty/11.3.0/13.0.0) | --- ### Release Notes <details> <summary>pinojs/pino-pretty (pino-pretty)</summary> ### [`v13.0.0`](https://github.com/pinojs/pino-pretty/releases/tag/v13.0.0) [Compare Source](pinojs/pino-pretty@v12.1.0...v13.0.0) #### What's Changed - chore: replace readable-stream with built-in stream by [@​benmccann](https://github.com/benmccann) in pinojs/pino-pretty#542 #### New Contributors - [@​benmccann](https://github.com/benmccann) made their first contribution in pinojs/pino-pretty#542 **Full Changelog**: pinojs/pino-pretty@v12.1.0...v13.0.0 ### [`v12.1.0`](https://github.com/pinojs/pino-pretty/releases/tag/v12.1.0) [Compare Source](pinojs/pino-pretty@v12.0.0...v12.1.0) #### What's Changed - fix: unescape \ for levelKey by [@​eliw00d](https://github.com/eliw00d) in pinojs/pino-pretty#538 **Full Changelog**: pinojs/pino-pretty@v12.0.0...v12.1.0 ### [`v12.0.0`](https://github.com/pinojs/pino-pretty/releases/tag/v12.0.0) [Compare Source](pinojs/pino-pretty@v11.3.0...v12.0.0) #### What's Changed - build(deps-dev): lock typescript minor version by [@​Fdawgs](https://github.com/Fdawgs) in pinojs/pino-pretty#534 - Bump typescript from 5.0.4 to 5.6.3 by [@​dependabot](https://github.com/dependabot) in pinojs/pino-pretty#535 - Drop support for Node.js 14 & 16 by [@​eliw00d](https://github.com/eliw00d) in pinojs/pino-pretty#540 #### New Contributors - [@​eliw00d](https://github.com/eliw00d) made their first contribution in pinojs/pino-pretty#540 **Full Changelog**: pinojs/pino-pretty@v11.3.0...v12.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xNDIuNyIsInVwZGF0ZWRJblZlciI6IjM4LjE0Mi43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/308 Reviewed-by: Alexandre Soro <code@soro.dev> Co-authored-by: renovate <renovate@git.tristess.app> Co-committed-by: renovate <renovate@git.tristess.app>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #541