Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: add injection of lacking arguments of customPrettifiers #501

Merged
merged 4 commits into from
Jun 9, 2024

Conversation

pasha-vuiko
Copy link
Contributor

resolves #500

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@pasha-vuiko
Copy link
Contributor Author

Thanks for opening a PR! Can you please add a unit test?

done

@pasha-vuiko pasha-vuiko changed the title fix: add injection lacking arguments of customPrettifiers fix: add injection of lacking arguments of customPrettifiers Mar 26, 2024
@pasha-vuiko pasha-vuiko requested a review from mcollina March 27, 2024 07:59
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

lib/utils/prettify-metadata.test.js Outdated Show resolved Hide resolved
@pasha-vuiko pasha-vuiko requested a review from jsumners March 31, 2024 13:59
@pasha-vuiko
Copy link
Contributor Author

@jsumners could you re-review please?

@pasha-vuiko
Copy link
Contributor Author

@jsumners hey 👋, what about re-review?🙂

@jsumners jsumners merged commit 84680aa into pinojs:master Jun 9, 2024
5 checks passed
renovate bot referenced this pull request in fwouts/previewjs Jun 16, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino-pretty](https://github.com/pinojs/pino-pretty) | [`^11.1.0` ->
`^11.2.1`](https://renovatebot.com/diffs/npm/pino-pretty/11.1.0/11.2.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino-pretty/11.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-pretty/11.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-pretty/11.1.0/11.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-pretty/11.1.0/11.2.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino-pretty (pino-pretty)</summary>

###
[`v11.2.1`](https://github.com/pinojs/pino-pretty/releases/tag/v11.2.1):
v11

[Compare
Source](https://github.com/pinojs/pino-pretty/compare/v11.2.0...v11.2.1)

#### What's Changed

- Fix: add missing useOnlyCustomProps options to type definitions by
[@&#8203;pcdevil](https://github.com/pcdevil) in
[https://github.com/pinojs/pino-pretty/pull/514](https://github.com/pinojs/pino-pretty/pull/514)

#### New Contributors

- [@&#8203;pcdevil](https://github.com/pcdevil) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/514](https://github.com/pinojs/pino-pretty/pull/514)

**Full Changelog**:
pinojs/pino-pretty@v11.2.0...v11.2.1

###
[`v11.2.0`](https://github.com/pinojs/pino-pretty/releases/tag/v11.2.0)

[Compare
Source](https://github.com/pinojs/pino-pretty/compare/v11.1.0...v11.2.0)

#### What's Changed

- fix: add injection of lacking arguments of customPrettifiers by
[@&#8203;pasha-vuiko](https://github.com/pasha-vuiko) in
[https://github.com/pinojs/pino-pretty/pull/501](https://github.com/pinojs/pino-pretty/pull/501)

#### New Contributors

- [@&#8203;pasha-vuiko](https://github.com/pasha-vuiko) made their
first contribution in
[https://github.com/pinojs/pino-pretty/pull/501](https://github.com/pinojs/pino-pretty/pull/501)

**Full Changelog**:
pinojs/pino-pretty@v11.1.0...v11.2.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/fwouts/previewjs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot referenced this pull request in open-feature/playground Jul 28, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino-pretty](https://github.com/pinojs/pino-pretty) | [`11.0.0` ->
`11.2.2`](https://renovatebot.com/diffs/npm/pino-pretty/11.0.0/11.2.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino-pretty/11.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-pretty/11.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-pretty/11.0.0/11.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-pretty/11.0.0/11.2.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino-pretty (pino-pretty)</summary>

###
[`v11.2.2`](https://github.com/pinojs/pino-pretty/releases/tag/v11.2.2)

[Compare
Source](https://github.com/pinojs/pino-pretty/compare/v11.2.1...v11.2.2)

#### What's Changed

- Type fixes by [@&#8203;joshkel](https://github.com/joshkel) in
[https://github.com/pinojs/pino-pretty/pull/522](https://github.com/pinojs/pino-pretty/pull/522)

#### New Contributors

- [@&#8203;joshkel](https://github.com/joshkel) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/522](https://github.com/pinojs/pino-pretty/pull/522)

**Full Changelog**:
pinojs/pino-pretty@v11.2.1...v11.2.2

###
[`v11.2.1`](https://github.com/pinojs/pino-pretty/releases/tag/v11.2.1):
v11

[Compare
Source](https://github.com/pinojs/pino-pretty/compare/v11.2.0...v11.2.1)

#### What's Changed

- Fix: add missing useOnlyCustomProps options to type definitions by
[@&#8203;pcdevil](https://github.com/pcdevil) in
[https://github.com/pinojs/pino-pretty/pull/514](https://github.com/pinojs/pino-pretty/pull/514)

#### New Contributors

- [@&#8203;pcdevil](https://github.com/pcdevil) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/514](https://github.com/pinojs/pino-pretty/pull/514)

**Full Changelog**:
pinojs/pino-pretty@v11.2.0...v11.2.1

###
[`v11.2.0`](https://github.com/pinojs/pino-pretty/releases/tag/v11.2.0)

[Compare
Source](https://github.com/pinojs/pino-pretty/compare/v11.1.0...v11.2.0)

#### What's Changed

- fix: add injection of lacking arguments of customPrettifiers by
[@&#8203;pasha-vuiko](https://github.com/pasha-vuiko) in
[https://github.com/pinojs/pino-pretty/pull/501](https://github.com/pinojs/pino-pretty/pull/501)

#### New Contributors

- [@&#8203;pasha-vuiko](https://github.com/pasha-vuiko) made their
first contribution in
[https://github.com/pinojs/pino-pretty/pull/501](https://github.com/pinojs/pino-pretty/pull/501)

**Full Changelog**:
pinojs/pino-pretty@v11.1.0...v11.2.0

###
[`v11.1.0`](https://github.com/pinojs/pino-pretty/releases/tag/v11.1.0)

[Compare
Source](https://github.com/pinojs/pino-pretty/compare/v11.0.0...v11.1.0)

#### What's Changed

- Bump tsd from 0.30.7 to 0.31.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-pretty/pull/503](https://github.com/pinojs/pino-pretty/pull/503)
- Fix Object.create(null) by
[@&#8203;chrisands](https://github.com/chrisands) in
[https://github.com/pinojs/pino-pretty/pull/507](https://github.com/pinojs/pino-pretty/pull/507)
- Bump sonic-boom from 3.8.1 to 4.0.1 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-pretty/pull/509](https://github.com/pinojs/pino-pretty/pull/509)
- Bump pino from 8.21.0 to 9.0.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino-pretty/pull/510](https://github.com/pinojs/pino-pretty/pull/510)
- feat: automatically consume pino config when using pino@>=8.21.0 by
[@&#8203;10xLaCroixDrinker](https://github.com/10xLaCroixDrinker) in
[https://github.com/pinojs/pino-pretty/pull/508](https://github.com/pinojs/pino-pretty/pull/508)
- fix: pass error-like objects
([#&#8203;505](https://github.com/pinojs/pino-pretty/issues/505)) by
[@&#8203;aqemi](https://github.com/aqemi) in
[https://github.com/pinojs/pino-pretty/pull/506](https://github.com/pinojs/pino-pretty/pull/506)
- Add node v22 to CI by
[@&#8203;mcollina](https://github.com/mcollina) in
[https://github.com/pinojs/pino-pretty/pull/511](https://github.com/pinojs/pino-pretty/pull/511)
- feat: Added exports color support in TTY by
[@&#8203;synapse](https://github.com/synapse) in
[https://github.com/pinojs/pino-pretty/pull/513](https://github.com/pinojs/pino-pretty/pull/513)

#### New Contributors

- [@&#8203;chrisands](https://github.com/chrisands) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/507](https://github.com/pinojs/pino-pretty/pull/507)
- [@&#8203;aqemi](https://github.com/aqemi) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/506](https://github.com/pinojs/pino-pretty/pull/506)
- [@&#8203;synapse](https://github.com/synapse) made their first
contribution in
[https://github.com/pinojs/pino-pretty/pull/513](https://github.com/pinojs/pino-pretty/pull/513)

**Full Changelog**:
pinojs/pino-pretty@v11.0.0...v11.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/open-feature/playground).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzguMCIsInVwZGF0ZWRJblZlciI6IjM3LjQzOC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZSJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PinoPretty.customPrettifiers() lacks arguments declared in type PinoPretty.Prettifier
3 participants