Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: bump serializer library, for https://github.com/pinojs/pino-std… #1410

Closed
wants to merge 1 commit into from

Conversation

Mechanicalkeyboard
Copy link

@Mechanicalkeyboard Mechanicalkeyboard commented Apr 19, 2022

@Mechanicalkeyboard Mechanicalkeyboard changed the title core: bump serializer library, for https://github.com/pinojs/pino-std… chore: bump serializer library, for https://github.com/pinojs/pino-std… Apr 19, 2022
@jsumners
Copy link
Member

This would incur a major bump for Pino. We will do that at some point, but I'm not sure we are ready for it yet. You can use the newer version of pino-std-serializers by providing them as serializers when creating your Pino instance -- https://getpino.io/#/docs/api?id=serializers-object

@voxpelli
Copy link
Contributor

I would have hoped this would get part of Fastify v4 as a bump in Pino major would have to wait for a Fastify major to be included there and that will I guess take a while before that happens

@mcollina
Copy link
Member

CI is failing, could you update it?

@voxpelli I cannot delay Fastify v4 further to do another pino major bump :(. We'll likely do a Fastify v5 / pino v8 combo once we are ready.

@voxpelli
Copy link
Contributor

@mcollina I totally understand, I should have caught this earlier if I wanted to push it :)

On a sidenote: Why didn't Dependabot suggest this update?

@kibertoad
Copy link
Contributor

@mcollina How much work would bump entail? I can contribute some effort if that helps

@mcollina mcollina added this to the v8 milestone May 31, 2022
@mcollina
Copy link
Member

@mcollina How much work would bump entail? I can contribute some effort if that helps

Check out https://github.com/pinojs/pino/milestone/4. The most important change that need to be finished is #1249

@kibertoad
Copy link
Contributor

@mcollina #1249 only needs conflicts resolved and CI passing, right? Will attempt that tonight.

@kibertoad
Copy link
Contributor

@voxpelli Meanwhile, will you be able to fix this PR?

@voxpelli
Copy link
Contributor

@kibertoad I can try, but since it’s not mine and I’m not a maintainer I can only open a new one that replaces this one

@kibertoad
Copy link
Contributor

@voxpelli that also works

@kibertoad
Copy link
Contributor

@voxpelli fastify v4 lands next Tuesday, so we need pino 8 this week. is it feasible to create a new PR by EOD tomorrow?

@mcollina
Copy link
Member

mcollina commented Jun 1, 2022

Superseded by #1449

@mcollina mcollina closed this Jun 1, 2022
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants