Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix deprecated dependency notation #1929

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Fix deprecated dependency notation #1929

merged 2 commits into from
Mar 31, 2024

Conversation

mbtools
Copy link
Contributor

@mbtools mbtools commented Mar 22, 2024

Minor change to replaces a semver v1 notation (with leading v) with semver v2.

PS: The npm semver package most likely will deprecate semver v1 support in next major.

Minor change to replaces a semver v1 notation (with leading `v`) with semver v2.

PS: The npm semver package most likely will deprecate semver v1 support in next major.
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I think it should be a caret.

@mbtools
Copy link
Contributor Author

mbtools commented Mar 31, 2024

Makes sense. Changed

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 06df1df into pinojs:master Mar 31, 2024
12 of 15 checks passed
@mbtools mbtools deleted the patch-1 branch March 31, 2024 21:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants