Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support file URLs when configuring multiple transports #1961

Merged
merged 1 commit into from
May 7, 2024

Conversation

haines
Copy link
Contributor

@haines haines commented Apr 30, 2024

pino currently supports file URLs in single transports

pino.transport({ target: "file:///path/to/transport.js" });

but in multiple transports it does not:

pino.transport({ targets: [{ target: "file:///path/to/transport.js" }] });

throws

{
  code: "ERR_INVALID_URL",
  input: "file://file:///path/to/transport.js",
}

This PR adds a check for the presence of the file:// prefix before prepending it to the target.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 3243b71 into pinojs:main May 7, 2024
2 checks passed
@haines haines deleted the multiple-transports-file-url-target branch May 7, 2024 17:58
drazisil referenced this pull request in rustymotors/server Jun 3, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino](https://getpino.io)
([source](https://github.com/pinojs/pino)) | [`^8.18.0` ->
`^9.0.0`](https://renovatebot.com/diffs/npm/pino/8.21.0/9.1.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino/9.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/9.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.21.0/9.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.21.0/9.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino (pino)</summary>

### [`v9.1.0`](https://github.com/pinojs/pino/releases/tag/v9.1.0)

[Compare
Source](https://github.com/pinojs/pino/compare/v9.0.0...v9.1.0)

#### What's Changed

- fix(transport-stream): Fix import error when using pkg with node v20
by [@&#8203;nagyszabi](https://github.com/nagyszabi) in
[https://github.com/pinojs/pino/pull/1949](https://github.com/pinojs/pino/pull/1949)
- Update LTS doc by [@&#8203;jsumners](https://github.com/jsumners) in
[https://github.com/pinojs/pino/pull/1955](https://github.com/pinojs/pino/pull/1955)
- Update pino types for browser.formatters by
[@&#8203;KatelynKim](https://github.com/KatelynKim) in
[https://github.com/pinojs/pino/pull/1946](https://github.com/pinojs/pino/pull/1946)
- add node v22 to CI by
[@&#8203;mcollina](https://github.com/mcollina) in
[https://github.com/pinojs/pino/pull/1953](https://github.com/pinojs/pino/pull/1953)
- Add Platformatic to sponsors by
[@&#8203;mcollina](https://github.com/mcollina) in
[https://github.com/pinojs/pino/pull/1956](https://github.com/pinojs/pino/pull/1956)
- Update h3 example by [@&#8203;mcollina](https://github.com/mcollina)
in
[https://github.com/pinojs/pino/pull/1968](https://github.com/pinojs/pino/pull/1968)
- Support file URLs when configuring multiple transports by
[@&#8203;haines](https://github.com/haines) in
[https://github.com/pinojs/pino/pull/1961](https://github.com/pinojs/pino/pull/1961)
- Adding support for mix\&match pipelines by
[@&#8203;dbacarel](https://github.com/dbacarel) in
[https://github.com/pinojs/pino/pull/1954](https://github.com/pinojs/pino/pull/1954)
- apply serializers to args once before asObject or transmit by
[@&#8203;emmyakin](https://github.com/emmyakin) in
[https://github.com/pinojs/pino/pull/1971](https://github.com/pinojs/pino/pull/1971)
- build(deps-dev): bump pino-pretty from 10.3.1 to 11.0.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1933](https://github.com/pinojs/pino/pull/1933)
- build(deps): bump sonic-boom from 3.8.1 to 4.0.1 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1960](https://github.com/pinojs/pino/pull/1960)
- build(deps): bump pino-std-serializers from 6.2.2 to 7.0.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1957](https://github.com/pinojs/pino/pull/1957)
- build(deps-dev): bump tsd from 0.30.7 to 0.31.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1937](https://github.com/pinojs/pino/pull/1937)
- build(deps): bump actions/dependency-review-action from 3 to 4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1894](https://github.com/pinojs/pino/pull/1894)
- build(deps): bump pnpm/action-setup from 2.4.0 to 3.0.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1913](https://github.com/pinojs/pino/pull/1913)
- Drop yarn support and update pnpm by
[@&#8203;mcollina](https://github.com/mcollina) in
[https://github.com/pinojs/pino/pull/1972](https://github.com/pinojs/pino/pull/1972)
- build(deps): bump thread-stream from 2.7.0 to 3.0.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1959](https://github.com/pinojs/pino/pull/1959)

#### New Contributors

- [@&#8203;nagyszabi](https://github.com/nagyszabi) made their first
contribution in
[https://github.com/pinojs/pino/pull/1949](https://github.com/pinojs/pino/pull/1949)
- [@&#8203;haines](https://github.com/haines) made their first
contribution in
[https://github.com/pinojs/pino/pull/1961](https://github.com/pinojs/pino/pull/1961)
- [@&#8203;emmyakin](https://github.com/emmyakin) made their first
contribution in
[https://github.com/pinojs/pino/pull/1971](https://github.com/pinojs/pino/pull/1971)

**Full Changelog**:
pinojs/pino@v9.0.0...v9.1.0

###
[`v9.0.0`](https://github.com/pinojs/pino/compare/v8.21.0...4f8ea32aa69ec94b2fb5561716a7701aec991ce7)

[Compare
Source](https://github.com/pinojs/pino/compare/v8.21.0...v9.0.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/rustymotors/server).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjM1MS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
Josh-Walker-GM referenced this pull request in redwoodjs/redwood Jul 21, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino](https://getpino.io)
([source](https://github.com/pinojs/pino)) | [`8.21.0` ->
`9.3.1`](https://renovatebot.com/diffs/npm/pino/8.21.0/9.3.1) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino/9.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino/9.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino/8.21.0/9.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino/8.21.0/9.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino (pino)</summary>

### [`v9.3.1`](https://github.com/pinojs/pino/releases/tag/v9.3.1)

[Compare
Source](https://github.com/pinojs/pino/compare/v9.3.0...v9.3.1)

**Full Changelog**:
pinojs/pino@v9.3.0...v9.3.1

###
[`v9.3.0`](https://github.com/pinojs/pino/compare/v9.2.0...92f2cee98e83d3f864b228a6e1dc29a31e54ba49)

[Compare
Source](https://github.com/pinojs/pino/compare/v9.2.0...v9.3.0)

### [`v9.2.0`](https://github.com/pinojs/pino/releases/tag/v9.2.0)

[Compare
Source](https://github.com/pinojs/pino/compare/v9.1.0...v9.2.0)

#### What's Changed

- shallow clone target options by
[@&#8203;mcollina](https://github.com/mcollina) in
[https://github.com/pinojs/pino/pull/1973](https://github.com/pinojs/pino/pull/1973)
- add logger instance as third parameter by
[@&#8203;emmyakin](https://github.com/emmyakin) in
[https://github.com/pinojs/pino/pull/1977](https://github.com/pinojs/pino/pull/1977)
- use boolean flag to ensure serializers are applied once by
[@&#8203;emmyakin](https://github.com/emmyakin) in
[https://github.com/pinojs/pino/pull/1976](https://github.com/pinojs/pino/pull/1976)
- suppport messageKey in pino/browser by
[@&#8203;emmyakin](https://github.com/emmyakin) in
[https://github.com/pinojs/pino/pull/1980](https://github.com/pinojs/pino/pull/1980)
- Fixing browser side child log issue
([#&#8203;960](https://github.com/pinojs/pino/issues/960)) child level
can now be set at cr… by
[@&#8203;stevel032](https://github.com/stevel032) in
[https://github.com/pinojs/pino/pull/1986](https://github.com/pinojs/pino/pull/1986)

#### New Contributors

- [@&#8203;stevel032](https://github.com/stevel032) made their first
contribution in
[https://github.com/pinojs/pino/pull/1986](https://github.com/pinojs/pino/pull/1986)

**Full Changelog**:
pinojs/pino@v9.1.0...v9.2.0

### [`v9.1.0`](https://github.com/pinojs/pino/releases/tag/v9.1.0)

[Compare
Source](https://github.com/pinojs/pino/compare/v9.0.0...v9.1.0)

#### What's Changed

- fix(transport-stream): Fix import error when using pkg with node v20
by [@&#8203;nagyszabi](https://github.com/nagyszabi) in
[https://github.com/pinojs/pino/pull/1949](https://github.com/pinojs/pino/pull/1949)
- Update LTS doc by [@&#8203;jsumners](https://github.com/jsumners) in
[https://github.com/pinojs/pino/pull/1955](https://github.com/pinojs/pino/pull/1955)
- Update pino types for browser.formatters by
[@&#8203;KatelynKim](https://github.com/KatelynKim) in
[https://github.com/pinojs/pino/pull/1946](https://github.com/pinojs/pino/pull/1946)
- add node v22 to CI by
[@&#8203;mcollina](https://github.com/mcollina) in
[https://github.com/pinojs/pino/pull/1953](https://github.com/pinojs/pino/pull/1953)
- Add Platformatic to sponsors by
[@&#8203;mcollina](https://github.com/mcollina) in
[https://github.com/pinojs/pino/pull/1956](https://github.com/pinojs/pino/pull/1956)
- Update h3 example by [@&#8203;mcollina](https://github.com/mcollina)
in
[https://github.com/pinojs/pino/pull/1968](https://github.com/pinojs/pino/pull/1968)
- Support file URLs when configuring multiple transports by
[@&#8203;haines](https://github.com/haines) in
[https://github.com/pinojs/pino/pull/1961](https://github.com/pinojs/pino/pull/1961)
- Adding support for mix\&match pipelines by
[@&#8203;dbacarel](https://github.com/dbacarel) in
[https://github.com/pinojs/pino/pull/1954](https://github.com/pinojs/pino/pull/1954)
- apply serializers to args once before asObject or transmit by
[@&#8203;emmyakin](https://github.com/emmyakin) in
[https://github.com/pinojs/pino/pull/1971](https://github.com/pinojs/pino/pull/1971)
- build(deps-dev): bump pino-pretty from 10.3.1 to 11.0.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1933](https://github.com/pinojs/pino/pull/1933)
- build(deps): bump sonic-boom from 3.8.1 to 4.0.1 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1960](https://github.com/pinojs/pino/pull/1960)
- build(deps): bump pino-std-serializers from 6.2.2 to 7.0.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1957](https://github.com/pinojs/pino/pull/1957)
- build(deps-dev): bump tsd from 0.30.7 to 0.31.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1937](https://github.com/pinojs/pino/pull/1937)
- build(deps): bump actions/dependency-review-action from 3 to 4 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1894](https://github.com/pinojs/pino/pull/1894)
- build(deps): bump pnpm/action-setup from 2.4.0 to 3.0.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1913](https://github.com/pinojs/pino/pull/1913)
- Drop yarn support and update pnpm by
[@&#8203;mcollina](https://github.com/mcollina) in
[https://github.com/pinojs/pino/pull/1972](https://github.com/pinojs/pino/pull/1972)
- build(deps): bump thread-stream from 2.7.0 to 3.0.0 by
[@&#8203;dependabot](https://github.com/dependabot) in
[https://github.com/pinojs/pino/pull/1959](https://github.com/pinojs/pino/pull/1959)

#### New Contributors

- [@&#8203;nagyszabi](https://github.com/nagyszabi) made their first
contribution in
[https://github.com/pinojs/pino/pull/1949](https://github.com/pinojs/pino/pull/1949)
- [@&#8203;haines](https://github.com/haines) made their first
contribution in
[https://github.com/pinojs/pino/pull/1961](https://github.com/pinojs/pino/pull/1961)
- [@&#8203;emmyakin](https://github.com/emmyakin) made their first
contribution in
[https://github.com/pinojs/pino/pull/1971](https://github.com/pinojs/pino/pull/1971)

**Full Changelog**:
pinojs/pino@v9.0.0...v9.1.0

###
[`v9.0.0`](https://github.com/pinojs/pino/compare/v8.21.0...4f8ea32aa69ec94b2fb5561716a7701aec991ce7)

[Compare
Source](https://github.com/pinojs/pino/compare/v8.21.0...v9.0.0)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/redwoodjs/redwood).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MzEuNCIsInVwZGF0ZWRJblZlciI6IjM3LjQzMS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants