-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
test: use fs.execFile instead of exec #2110
Conversation
Generally safer than building a shell script, and allows to run the tests from a directory with spaces in it.
Example failure
|
/cc @mcollina It would be nice if we could have a release after this to have a green module in citgm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Damn, on Windows I guess it would have to be |
either works, or you can just skip this in citgm. |
let's just skip this test if CITGM is set |
It doesn't only fix citgm. It's quite common on Windows to have folders with spaces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Generally safer than building a shell script, and allows to run the
tests from a directory with spaces in it.