[#11912] Fix missing close on Jar InputStream in Plugin

pinpoint-apm · Jan 7, 2025 · 7700b04 · 7700b04
1 parent a36ab5a
commit 7700b04
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/...ap-java9/src/main/java/com/navercorp/pinpoint/bootstrap/java9/module/JarFileAnalyzer.java b/...ap-java9/src/main/java/com/navercorp/pinpoint/bootstrap/java9/module/JarFileAnalyzer.java
@@ -95,13 +95,16 @@ public Providers apply(JarEntry jarEntry) {
             if (jarEntryName.indexOf('/', SERVICE_LOADER.length()) != -1) {
                 return null;
             }
-            try {
-                InputStream inputStream = jarFile.getInputStream(jarEntry);
 
+            List<String> serviceImplClassName = readServiceProviderConfig(jarEntry);
+            String serviceClassName = jarEntryName.substring(SERVICE_LOADER.length());
+            return new Providers(serviceClassName, serviceImplClassName);
+        }
+
+        private List<String> readServiceProviderConfig(JarEntry jarEntry) {
+            try (InputStream inputStream = jarFile.getInputStream(jarEntry)) {
                 ServiceDescriptorParser parser = new ServiceDescriptorParser();
-                List<String> serviceImplClassName = parser.parse(inputStream);
-                String serviceClassName = jarEntryName.substring(SERVICE_LOADER.length());
-                return new Providers(serviceClassName, serviceImplClassName);
+                return parser.parse(inputStream);
             } catch (IOException e) {
                 throw new IllegalStateException(jarFile.getName() + " File read fail ", e);
             }