Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduce trace scope for asynchronous calls made by the Thrift client #1319

Closed
Xylus opened this issue Dec 4, 2015 · 0 comments
Closed

Reduce trace scope for asynchronous calls made by the Thrift client #1319

Xylus opened this issue Dec 4, 2015 · 0 comments
Assignees
Milestone

Comments

@Xylus
Copy link
Contributor

Xylus commented Dec 4, 2015

The current implementation of the asynchronous tracing model cannot guarantee the closure of AsyncTrace unless it spans a single method.

For tracing asynchronous calls made by Thrift clients, the AsyncTrace begins in TAsyncMethodCall.start() and ends in one of TAsyncMethodCall.doWritingRequestBody(), TAsyncMethodCall.doReadingResponseBody(), or TAsyncMethodCall.onError().

If in future versions of Thrift adds a new code path that passes through TAsyncMethodCall.start() but not the one of ending methods, the AsyncTrace will be pushed(start) but not popped(end).

To prevent these situations from every becoming a problem, it might be a good idea to reduce the scope of AsyncTrace to the ending methods. The trace data might not be as detailed, but it would be safer this way.

@Xylus Xylus self-assigned this Dec 4, 2015
@Xylus Xylus added this to the 1.5.2 milestone Dec 4, 2015
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 10, 2016
dawidmalina pushed a commit to dawidmalina/pinpoint that referenced this issue Mar 20, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant