Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support ActiveMQ java client #1709

Closed
Xylus opened this issue Apr 22, 2016 · 10 comments
Closed

Support ActiveMQ java client #1709

Xylus opened this issue Apr 22, 2016 · 10 comments
Assignees
Milestone

Comments

@Xylus
Copy link
Contributor

Xylus commented Apr 22, 2016

Add plugin to support ActiveMQ java client tracing.

Queue / Topic names will be used for virtual queue nodes.

Initial implementation supports v5.1.0+ and clients that connect using TCP based transport (so embedded queues that are connected via VM transports are not traced).

Trace methods might need to be more detailed (such as for redeliveries and transactions/rollbacks. These should be added in the future if deemed important.

@Xylus Xylus self-assigned this Apr 22, 2016
@Xylus Xylus added this to the 1.6.0 milestone Apr 22, 2016
@dawidmalina
Copy link
Contributor

@Xylus when do you plan to merge your changes to master branch?

@Xylus
Copy link
Contributor Author

Xylus commented May 11, 2016

@dawidmalina Ironing out some issues, should be in there by tomorrow :)

@chengruyi
Copy link

i have some problem whit activemq plugin , icon of activemq cannot display
image

@Xylus
Copy link
Contributor Author

Xylus commented May 13, 2016

@ruizlake looks like the image is missing. Could you check if you can access $PINPOINT_WEB_URL/images/servermap/ACTIVEMQ_CLIENT.png?

@chengruyi
Copy link

yes. i can access $PINPOINT_WEB_URL/images/servermap/ACTIVEMQ_CLIENT.png. but still it no working.All the configuration in accordance with the way you write Xylus@0317a98

@Xylus
Copy link
Contributor Author

Xylus commented May 13, 2016

Looks like the minified version of js files were not committed, and I'm not sure if these need to be merged into the repository. I'll check with @denzelsN and add them if necessary.

In the mean time, you could make the following changes to manually update them:

in pinpoint.min.js, change
a.isWas===!1&&"USER"!==a.serviceType
to
a.isWas===!1&&a.isQueue===!1&&"USER"!==a.serviceType

in pinpoint-component.min.js, change
htIcons:{APACHE:"APACHE.png"
to
htIcons:{ACTIVEMQ_CLIENT:"ACTIVEMQ_CLIENT.png",APACHE:"APACHE.png"

Let me know if this doesn't work.

@chengruyi
Copy link

thank you very much! it success. i love you ___

@Xylus
Copy link
Contributor Author

Xylus commented May 14, 2016

@ruizlake Glad it worked out :)
Also, if you update the Web code to 1.6.0-SNAPSHOT (the current master), it should just work without the modification above.
Please give it a try and let us know if it doesn't work.

@chengruyi
Copy link

ok.If found in the use of bug, I will be the first time to reply to you. thanks again

@chengruyi
Copy link

With your help, I developed a plug-in called rocketmq.if you want i will show about this plugin

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants