Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Trace data lost when using older Oracle jdbc drivers (10.x and older) #193

Closed
Xylus opened this issue Feb 26, 2015 · 1 comment
Closed

Trace data lost when using older Oracle jdbc drivers (10.x and older) #193

Xylus opened this issue Feb 26, 2015 · 1 comment
Assignees
@Xylus
Labels
bug
Milestone
1.5.0

Comments

@Xylus
Copy link
Contributor

Xylus commented Feb 26, 2015

Pinpoint currently hooks on to OracleStatementWrapper and OraclePreparedStatementWrapper to trace calls to Oracle databases.

Older Oracle jdbc drivers (10.x and older) do not have wrapper classes for statements and leaves a hole in the tracing pipeline for Oracle database calls.
@Xylus Xylus added the bug label Feb 26, 2015
@Xylus Xylus self-assigned this Feb 26, 2015
@Xylus
Copy link
Contributor Author

Xylus commented Feb 26, 2015

Resolving issue by adding modifiers for OracleStatement and OraclePreparedStatement that injects interceptors only when their respective wrapper classes are not found.

Xylus added a commit to Xylus/pinpoint that referenced this issue Feb 26, 2015
@Xylus
added support for older Oracle JDBC drivers (10.x) - fixes pinpoint-a…
79c13cb 
…pm#193
@Xylus Xylus closed this as completed in 882a810 Feb 26, 2015
Xylus added a commit that referenced this issue Feb 26, 2015
@Xylus
Merge pull request #194 from Xylus/bugfix/issue-193
3918320 
Added support for older Oracle jdbc drivers - fixes #193
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 3, 2015
@Xylus
added support for older Oracle JDBC drivers (10.x) - fixes pinpoint-a…
c9e80cc 
…pm#193
Xylus added a commit that referenced this issue Mar 3, 2015
@Xylus
Merge pull request #202 from Xylus/1.0.x
1652991 
Back-porting fix for #193
@emeroad emeroad added this to the 1.1.0 milestone Mar 17, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Xylus Xylus

Labels
bug
Projects
None yet
Milestone
1.5.0
Development

No branches or pull requests
2 participants
@emeroad @Xylus