Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Provide a better way to figure out the application type. #195

Closed
Xylus opened this issue Feb 26, 2015 · 0 comments · Fixed by #242
Closed

Provide a better way to figure out the application type. #195

Xylus opened this issue Feb 26, 2015 · 0 comments · Fixed by #242
Assignees
@Xylus
Labels
enhancement
Milestone
1.5.0

Comments

@Xylus
Copy link
Contributor

Xylus commented Feb 26, 2015

Currently, determining the application type (ie Tomcat) of the agent application is somewhat lacking.
It requires hard-coded checks and too much of the responsibility is passed onto each of the plugins.

There needs to be a way for the plugins to simply define their requirements according to some pre-defined conditions, and have a centralized logic to check those requirements to determine the application type.
@Xylus Xylus self-assigned this Feb 26, 2015
Xylus added a commit to Xylus/pinpoint that referenced this issue Feb 27, 2015
@Xylus
implemented application type detector - pinpoint-apm#195
f86578f
Xylus added a commit to Xylus/pinpoint that referenced this issue Feb 27, 2015
@Xylus
implemented application type detector - pinpoint-apm#195
7c7327f
Xylus added a commit to Xylus/pinpoint that referenced this issue Feb 27, 2015
@Xylus
refactored to allow adding custom conditions to type detectors - pinp…
3814eb0 
…oint-apm#195
Xylus added a commit to Xylus/pinpoint that referenced this issue Feb 27, 2015
@Xylus
implemented application type detector - pinpoint-apm#195
fcfe553
Xylus added a commit to Xylus/pinpoint that referenced this issue Feb 27, 2015
@Xylus
implemented application type detector - pinpoint-apm#195
0af6761
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 9, 2015
@Xylus
implemented application type detector - pinpoint-apm#195
c6f32da
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 9, 2015
@Xylus
implemented application type detector - pinpoint-apm#195
05d5423
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 10, 2015
@Xylus
implemented application type detector - pinpoint-apm#195
6313309
@emeroad emeroad added this to the 1.1.0 milestone Mar 17, 2015
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 19, 2015
@Xylus
[pinpoint-apm#195] implemented application type detector
86797fc
@Xylus Xylus mentioned this issue Mar 19, 2015
Merged
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 19, 2015
@Xylus
[pinpoint-apm#195] implemented application type detector
a291356
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 19, 2015
@Xylus
[pinpoint-apm#195] implemented application type detector
185860b
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 20, 2015
@Xylus
[pinpoint-apm#195] implemented application type detector
7bb79fa
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 20, 2015
@Xylus
[pinpoint-apm#195] simplified API for ConditionProvider
7268a83
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 20, 2015
@Xylus
[pinpoint-apm#195] implemented application type detector
3113fe4
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 20, 2015
@Xylus
[pinpoint-apm#195] simplified API for ConditionProvider
b34ad94
Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 20, 2015
@Xylus
[pinpoint-apm#195] simplified API for ConditionProvider
7d19413
Xylus added a commit that referenced this issue Mar 23, 2015
@Xylus
Merge pull request #242 from Xylus/feature/issue-195
4f7b759 
[#195] Provided a simpler way for plugins to decide the application's type.
Xylus added a commit to Xylus/pinpoint that referenced this issue Jun 3, 2015
@Xylus
pinpoint-apm#195 changed logging to use binded logger and added debug…
cec3be6 
… logs
Xylus added a commit that referenced this issue Jun 3, 2015
@Xylus
Merge pull request #534 from Xylus/feature/issue-195
e0f962d 
#195 changed logging to use binded logger and added debug logs
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Xylus Xylus

Labels
enhancement
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

[#195] Provided a simpler way for plugins to decide the application's type. Xylus/pinpoint
2 participants
@emeroad @Xylus