Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

when Hystrix's fallback() method is called,succes or fail? #2101

Closed
zcmjcd1 opened this issue Sep 21, 2016 · 4 comments
Closed

when Hystrix's fallback() method is called,succes or fail? #2101

zcmjcd1 opened this issue Sep 21, 2016 · 4 comments
Assignees
@Xylus
Labels
enhancement proposal
Milestone
1.6.0

Comments

@zcmjcd1
Copy link

zcmjcd1 commented Sep 21, 2016

For version 1.6.0 ,when fallback()method is called ,it is regared as a success,but it's really a fail,how can I fix it?
Thanks
@Xylus
Copy link
Contributor

Xylus commented Sep 22, 2016

@zcmjcd1 Looking into this currently and trying to come up with something to indicate that the fallback method has run.
Thanks for sharing!

@zcmjcd1
Copy link
Author

zcmjcd1 commented Sep 22, 2016

Thank you!

@Xylus Xylus added this to the 1.6.0 milestone Sep 26, 2016
@Xylus Xylus self-assigned this Sep 26, 2016
Xylus added a commit to Xylus/pinpoint that referenced this issue Sep 27, 2016
@Xylus
pinpoint-apm#2101 Add fallback method tracing
cf55096
Xylus added a commit to Xylus/pinpoint that referenced this issue Sep 27, 2016
@Xylus
pinpoint-apm#2101 Add integration tests for tracing fallbacks and pro…
3ceacdd 
…pagation
Xylus added a commit to Xylus/pinpoint that referenced this issue Oct 18, 2016
@Xylus
pinpoint-apm#2101 Add fallback method tracing
913cd50
Xylus added a commit to Xylus/pinpoint that referenced this issue Oct 18, 2016
@Xylus
pinpoint-apm#2101 Add integration tests for tracing fallbacks and pro…
8bb3a82 
…pagation
Xylus added a commit that referenced this issue Nov 1, 2016
@Xylus
#2101 Add fallback method tracing
48a607c
Xylus added a commit that referenced this issue Nov 1, 2016
@Xylus
#2101 Add integration tests for tracing fallbacks and propagation
284642e
@Xylus
Copy link
Contributor

Xylus commented Nov 1, 2016

@zcmjcd1
Hystrix should mostly indicate if a fallback method is run - #2109.
Please do test it out and let us know if anything looks weird.
Thanks!

@Xylus
Copy link
Contributor

Xylus commented Nov 1, 2016

@zcmjcd1 Feel free to reopen the issue if it doesn't work.

@Xylus Xylus closed this as completed Nov 1, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Xylus Xylus

Labels
enhancement proposal
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@Xylus @zcmjcd1