Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Change default instrumentation engine to ASM #2215

Closed
Xylus opened this issue Nov 2, 2016 · 3 comments
Closed

Change default instrumentation engine to ASM #2215

Xylus opened this issue Nov 2, 2016 · 3 comments
Assignees
@Xylus
Labels
enhancement
Milestone
1.6.0

Comments

@Xylus
Copy link
Contributor

Xylus commented Nov 2, 2016

Starting from 1.6.0, agent's bytecode instrumentation will use ASM instead of Javassist.
@Xylus Xylus added this to the 1.6.0 milestone Nov 2, 2016
@Xylus Xylus self-assigned this Nov 2, 2016
Xylus added a commit to Xylus/pinpoint that referenced this issue Nov 2, 2016
@Xylus
pinpoint-apm#2215 Change default instrumentation engine to ASM
e7a07a7
Xylus added a commit that referenced this issue Nov 2, 2016
@Xylus
#2215 Change default instrumentation engine to ASM
a2ff727
@Xylus
Copy link
Contributor Author

Xylus commented Nov 2, 2016

merged via #2216

@Xylus Xylus closed this as completed Nov 2, 2016
@otisg
Copy link

otisg commented Nov 4, 2016

Btw. why did you decide on this change?

@Xylus
Copy link
Contributor Author

Xylus commented Nov 4, 2016

Hi @otisg
It was mostly due to performance/feature reasons, ASM seemed to offer better performance and faster startup time, and more features for the agent to expand upon.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Xylus Xylus

Labels
enhancement
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
2 participants
@otisg @Xylus