Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Decouple application type and traced span type. #228

Closed
Xylus opened this issue Mar 12, 2015 · 1 comment · Fixed by #233
Closed

Decouple application type and traced span type. #228

Xylus opened this issue Mar 12, 2015 · 1 comment · Fixed by #233
Assignees
@Xylus
Labels
enhancement
Milestone
1.5.0

Comments

@Xylus
Copy link
Contributor

Xylus commented Mar 12, 2015

Currently, transaction traces do not carry any information about the application type that they stemmed from. This introduces a limitation to profiled applications as they must be of the same type as the API that generates the root spans. Additionally, applications are limited to being able to trace only a single type of service.
Normal web containers such as Tomcat are not affected by this limitation, but standalone applications including Spring Boot, and others that use embedded containers will all be effected.

An example of this would be a standalone application that runs embedded Tomcat internally. Tomcat interceptors would generate trace data just fine, but none of them will show up on the server map.

Decoupling application type and the traced span type would solve this issue.
@Xylus Xylus self-assigned this Mar 12, 2015
@Xylus
Copy link
Contributor Author

Xylus commented Mar 12, 2015

The current quickstart project has the exact same problem, and is worked around by setting the application type to "TOMCAT" manually inside the pinpoint.config file.

Xylus added a commit to Xylus/pinpoint that referenced this issue Mar 17, 2015
@Xylus
[pinpoint-apm#228] Decouple application type and span service type.
2a5f939 
Every span/spanChunk is now created with an extra field holding
application service type. This field is then used exclusively for
drawing the server map.

Previously, the server map nodes/links were extrapolated from the
span/spanChunk's service type, and this made it impossible for the
application type to work independently from their span service type.

This change not only decouples the application type from their
span service type, but also allows an application to have
multiple services that create root spans.

To maintain backwards compatibility, traces that do not have an
application type will default to their original service type.
@Xylus Xylus mentioned this issue Mar 17, 2015
Merged
@emeroad emeroad added this to the 1.1.0 milestone Mar 17, 2015
Xylus added a commit that referenced this issue Mar 17, 2015
@Xylus
Merge pull request #233 from Xylus/feature/issue-228
ef9fd01 
[#228] Decouple application type and span service type.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Xylus Xylus

Labels
enhancement
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

[#228] Decouple application type and span service type. Xylus/pinpoint
2 participants
@emeroad @Xylus