Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add profiling support for Thrift services #329

Closed
Xylus opened this issue Apr 15, 2015 · 1 comment · Fixed by #891
Closed

Add profiling support for Thrift services #329

Xylus opened this issue Apr 15, 2015 · 1 comment · Fixed by #891
Assignees
@Xylus
Labels
enhancement module:plugin
Milestone
1.5.0

Comments

@Xylus
Copy link
Contributor

Xylus commented Apr 15, 2015

Thrift services may be traced by intercepting Thrift clients, and Thrift processors.
These interception points are:

  • Client
    • org.apache.thrift.TServiceClient
    • org.apache.thrift.async.TAsyncClient
  • Processor (Server)
    • org.apache.thrift.TBaseProcessor
    • org.apache.thrift.TBaseAsyncProcessor
  • TTransport - for retrieving connection info
    • org.apache.thrift.transport.TSocket
    • org.apache.thrift.transport.TNonblockingSocket
    • Decorator Transports that wrap the above 2 TTransports
      • org.apache.thrift.transport.TFramedTransport
      • org.apache.thrift.transport.TFastFramedTransport
      • org.apache.thrift.transport.TSaslClientTransport
    • Memory based Transport for FrameBuffers in non-blocking servers
      • org.apache.thrift.transport.TMemoryInputTransport
  • TProtocol - for reading/writing trace headers
    • org.apache.thrift.protocol.TBinaryProtocol
    • org.apache.thrift.protocol.TCompactProtocol
    • org.apache.thrift.protocol.TJSONProtocol
    • Support for org.apache.thrift.protocol.TTupleProtocol may also be possible

There are 4 main interception groups for tracing various Thrift operations.

  • Client synchronous send/receive
  • Client asynchronous send/receive
  • Server synchronous processing
  • Server asynchronous processing

Each of these operations work similarly by utilizing the interception points above:

  1. Client/Processor interceptors - Mark trace points and record connection information retrieved by (2).
  2. TTransport interceptors - Retrieve connection information from the root TTransport object (TSocket/TNonblockingSocket)
  3. TProtocol interceptors - Read/Write parent trace information track remote traces.

Will test against Thrift v0.8.0+ except for asynchronous processors which have been added in 0.9.1.
@Xylus Xylus self-assigned this Apr 15, 2015
@Xylus Xylus added this to the 1.1.0 milestone Apr 15, 2015
@nstopkimsk nstopkimsk modified the milestones: 1.0.5, 1.1.0 Apr 16, 2015
Xylus added a commit to Xylus/pinpoint that referenced this issue May 29, 2015
@Xylus
pinpoint-apm#329 added profiling support for synchronous processor/cl…
3ccc43c 
…ient operations
Xylus added a commit to Xylus/pinpoint that referenced this issue May 29, 2015
@Xylus
pinpoint-apm#329 added integration tests for profiling Thrift synchro…
0032397 
…nous operations
Xylus added a commit to Xylus/pinpoint that referenced this issue May 29, 2015
@Xylus
pinpoint-apm#329 added profiling support for asynchronous processor o…
357e185 
…perations
Xylus added a commit to Xylus/pinpoint that referenced this issue May 29, 2015
@Xylus
pinpoint-apm#329 added integration tests for profiling Thrift asynchr…
2c47ff7 
…onous processor

operations
Xylus added a commit to Xylus/pinpoint that referenced this issue May 29, 2015
@Xylus
pinpoint-apm#329 removed preloading code
3a802d7
Xylus added a commit to Xylus/pinpoint that referenced this issue May 29, 2015
@Xylus
pinpoint-apm#329 added support for async client calls
4d56026
Xylus added a commit to Xylus/pinpoint that referenced this issue May 29, 2015
@Xylus
pinpoint-apm#329 add profiling support for Thrift services
537e541
Xylus added a commit to Xylus/pinpoint that referenced this issue May 29, 2015
@Xylus
pinpoint-apm#329 add integration tests for Thrift plugin
633f903
@Xylus Xylus mentioned this issue May 29, 2015
Merged
Xylus added a commit to Xylus/pinpoint that referenced this issue Jun 1, 2015
@Xylus
pinpoint-apm#329 modify ITs to retrieve hostnames from InetSocketAddress
c499fcd
Xylus added a commit that referenced this issue Jun 1, 2015
@Xylus
Merge pull request #513 from Xylus/feature/issue-329
4a64a2a 
#329 modify ITs to retrieve hostnames from InetSocketAddress
Xylus added a commit to Xylus/pinpoint that referenced this issue Jun 1, 2015
@Xylus
pinpoint-apm#329 added hostname modification to Annotation checks
dc3545b
Xylus added a commit that referenced this issue Jun 1, 2015
@Xylus
Merge pull request #514 from Xylus/feature/issue-329
ab5d23d 
#329 added hostname modification to Annotation checks
Xylus added a commit to Xylus/pinpoint that referenced this issue Jun 5, 2015
@Xylus
pinpoint-apm#329 refactored Thrift trace headers
fa35b1c 
This was done to ease up future refactoring that would pull up trace
headers used for tracing various RPC calls into a single common class.
Xylus added a commit that referenced this issue Jun 5, 2015
@Xylus
Merge pull request #551 from Xylus/feature/issue-329
333361a 
#329 refactored Thrift trace headers
Xylus added a commit to Xylus/pinpoint that referenced this issue Jun 19, 2015
@Xylus
pinpoint-apm#329 seperated client/server verification due to potentia…
cbb722b 
…l timing issues

* Span/SpanEvent order for client/server traces cannot be guaranteed
with the current implementation of OrderedSpanRecorder. Client/server
trace verification tests are therefore seperated.
* Async call tests are disabled as well as the current implementation of
OrderedSpanRecorder does not adequately support async client SpanEvents.
A modification should be in place soon, and these tests will be added to
the suite when that happens.
Xylus added a commit to Xylus/pinpoint that referenced this issue Jul 14, 2015
@Xylus
[pinpoint-apm#329] add integration tests for asynchronous client calls
9ae356f
Xylus added a commit to Xylus/pinpoint that referenced this issue Jul 14, 2015
@Xylus
[pinpoint-apm#329] add integration tests for asynchronous client calls
ba54f04
Xylus added a commit to Xylus/pinpoint that referenced this issue Jul 14, 2015
@Xylus
[pinpoint-apm#329] fix issue where Processors create an extra span event
7ff6dd4
@Xylus
Copy link
Contributor Author

Xylus commented Aug 27, 2015

Thrift integration tests may fail occasionally when a new test starts and creates a socket on a port which wasn't properly released (or is still in the process) by the previous test.

@Xylus Xylus reopened this Aug 27, 2015
@Xylus Xylus mentioned this issue Aug 27, 2015
Merged
@Xylus Xylus mentioned this issue Nov 16, 2017
Closed
Xylus added a commit to Xylus/pinpoint that referenced this issue Nov 9, 2018
@Xylus
[pinpoint-apm#329] Trim "_call" suffix from async call method name
528f9a9
Xylus added a commit that referenced this issue Nov 9, 2018
@Xylus
[#329] Trim "_call" suffix from async call method name
6a5be1a
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Xylus Xylus

Labels
enhancement module:plugin
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Allow tests to use different ports for different test runs Xylus/pinpoint
2 participants
@nstopkimsk @Xylus