Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

apache cxf plugin for client #1994

Merged
merged 1 commit into from
Aug 22, 2016
Merged

apache cxf plugin for client #1994

merged 1 commit into from
Aug 22, 2016

Conversation

barneykim
Copy link
Contributor

#142 apache cxf plugin for client

@barneykim
Copy link
Contributor Author

I saw Plugin Developer Guide and learned that missed some important steps for PR.
I didn't contact the Pinpoint dev team for the following:

  • ServiceType code
  • AnnotationType code

@nstopkimsk
Copy link
Contributor

@barneykim Long time no see. Don't worry about it. We will review your pr. thanks.

@emeroad emeroad merged commit 6db1b6a into pinpoint-apm:master Aug 22, 2016
@emeroad
Copy link
Member

emeroad commented Aug 22, 2016

LGTM 👍

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barneykim @nstopkimsk @emeroad