Pinpoint Jboss Plugin #2001
Pinpoint Jboss Plugin #2001
Conversation
| c = classLoader.loadClass(className); | ||
| // Using different approach to load classes via classloader | ||
| // c = classLoader.loadClass(className); | ||
| c = Class.forName(className, false, classLoader); |
There was a problem hiding this comment.
Hello~ suraj-raturi
Why did this code change?
Tell me the reason to change.
There was a problem hiding this comment.
Hi @emeroad
Classloader can load classes via both the ways:
- classLoader.loadClass
- Class.forName
With classLoader.loadClass I was facing linkage error for example - "Caused by: java.lang.LinkageError: loader (instance of org/jboss/modules/ModuleClassLoader): attempted duplicate class definition for name: "com/navercorp/pinpoint/plugin/jdbc/mysql/MySqlConstants", while agent was instrumenting class in jboss environment.
I looked at the alternative ways to load classes in multi-threaded environment as the issue of linkage error has been reported by many (not specifically with Jboss) with classloader.loadClass.
I tried to load class with Class.forName, it worked for me without any issues for Jboss. To be absolutely sure that it won't break anything, I tested it with Tomcat environment as well and it worked fine.
Let me know your thoughts.
Thanks,
Suraj
There was a problem hiding this comment.
Hello. @suraj-raturi
I have a good news.
We solved JDKLogger problem in jboss. #2026
We will solved Concurrent ClassLoading problem.
There was a problem hiding this comment.
Hi @emeroad ,
Thats good news, our approach while working for Jboss plugin was to go for minimum code change in existing Pinpoint project.
So, we choosed to solve the logger problem via defining logmanager property and logmanager jar in Jboss configuration.
Regarding Classloading issue, will be happy to be involve in the discussion and would like to contribute as well, if a more better approach from above code change in PlainClassLoaderHandler can be done.
Thanks
There was a problem hiding this comment.
Hi @suraj-raturi
I fixed the JBoss CL issue from #2117
But This PR need to modify setting.
plugins/jboss/README.md
-Djboss.modules.system.pkgs=com.navercorp.pinpoint
-Djboss.modules.system.pkgs=com.navercorp.pinpoint.bootstrap,
com.navercorp.pinpoint.common,
com.navercorp.pinpoint.exception
There was a problem hiding this comment.
Hi @emeroad ,
I have updated the README file.
Thanks
|
Would be nice to see this plugin with pinpoint 1.6.0 |
- fix conflict.
|
Hi @suraj-raturi |
|
Hi @emeroad , |
- add .gitignore & clover.license
- add .gitignore & clover.license
- avoid transform class collision (Tomcat plugin) - add emporary option : profile.jboss.enable=false (+1 squashed commits)
- avoid transform class collision (Tomcat plugin) - add temporary option : profile.jboss.enable=false
- avoid transform class collision (Tomcat plugin) - add temporary option : profile.jboss.enable=false
- avoid transform class collision (Tomcat plugin) - add temporary option : profile.jboss.enable=false
- fix testcase fail
- fix testcase fail
- fix testcase fail
|
There is currently a bug in our ASM engine - You must set |
@Xylus - Here raising PR for Jboss plugin, Please have a look and let us know if you see any issue
#972 Tested on Jboss EAP version - 6.4.x, We are in process of checking the compatibility with other versions as well.