Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add asm instrument #2017

Merged
merged 1 commit into from
Aug 29, 2016
Merged

add asm instrument #2017

merged 1 commit into from
Aug 29, 2016

Conversation

jaehong-kim
Copy link
Contributor

@jaehong-kim jaehong-kim added this to the 1.6.0 milestone Aug 29, 2016
@jaehong-kim jaehong-kim self-assigned this Aug 29, 2016
@jaehong-kim jaehong-kim merged commit dad7f6d into pinpoint-apm:master Aug 29, 2016
@jiaqifeng
Copy link
Contributor

@jaehong-kim
I tried to read the code while it was really many! I just want to know can I instrument all sub-class of a specified base class?
I contributed the hystrix plugin. In hystrix, user inherit from HystrixCommand and implement the abstract method run(). This run() method should be intercepted but pinpoint previous release could only inspect a class you know its class name. All I want is to intercept run() method of all sub-class of HystrixCommand.
Can this PR support what I want? If not, will you consider support it in the future?

@jaehong-kim
Copy link
Contributor Author

Not yet supported.
Performance is still difficult to check for inheritance between classes.

But someday we will support it.

@jiaqifeng
Copy link
Contributor

@jaehong-kim
So you use ASM to replace Javassist just to improve performance? I have seen another APM using ASM and support what I want. While search in inheritance really will slow the boot time a lot. But you know, most apps boot time exceed a half minutes, it is not acceptable to double the boot time. ^-^

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants