Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add jackson plugin #466

Closed
wants to merge 4 commits into from
Closed

add jackson plugin #466

wants to merge 4 commits into from

Conversation

skkeem
Copy link
Contributor

@skkeem skkeem commented May 25, 2015

added jackson plugin

covers ObjectMapper constructors, readValue, writeValue, writeValueAsString, writeValueAsBytes

skkeem added 4 commits May 25, 2015 19:38
refined the plugin to match the conventions
this includes integration test, objectmapper execution policies, readvalue interceptors
@skkeem
Copy link
Contributor Author

skkeem commented Jun 4, 2015

말씀하신 부분들은 다 수정하였습니다
ExecutionPolicy.INTERNAL의 경우도 삭제하는 방식으로 하였습니다.

@lioolli
Copy link
Contributor

lioolli commented Jun 5, 2015

충돌나는 것도 있고 해서 수동으로 머지해서 반영했습니다~ 감사합니다.

ExecutionPolicy.INTERNAL 문제는 생각보다 좀 더 복잡한 상황입니다.
INTERNAL로 하면 그 생성자를 직접 불러도 기록이 안 되고
BOUNDARY 그러니까 기본값이 맞는데, 자바의 생성자 특성때문에 이게 안 먹히는 상황입니다.
플러그인이 아니라 코어쪽에서 해법을 찾아야 하는 문제라서 일단은 그대로 두고 가도록 하겠습니다.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants