Jetty Plugin (sync) #771
Jetty Plugin (sync) #771
Conversation
| @@ -140,6 +140,8 @@ public static ProfilerConfig load(String pinpointConfigFileName) throws IOExcept | |||
| private boolean memcached = true; | |||
| private boolean memcachedKeyTrace = false; | |||
|
|
|||
| private Filter<String> jettyExcludeUrlFilter = new SkipFilter<String>(); | |||
There was a problem hiding this comment.
This field is not used anywhere. You'd better remove it.
There was a problem hiding this comment.
If I'm not mistaken I needed this field as a default for filtering within the ServerHandleInterceptor:
final String requestURI = request.getRequestURI();
if (excludeUrlFilter.filter(requestURI)) {
if (isTrace) {
logger.trace("filter requestURI:{}", requestURI);
}
return null;
}
There was a problem hiding this comment.
excludedUrlFilter comes from JettyConfiguration not ProfilerConfig.
There was a problem hiding this comment.
JettyConfiguration uses ProfilerConfig though:
public JettyConfiguration(ProfilerConfig config) {
final String jettyExcludeURL = config.readString("profiler.jetty.excludeurl", "");
if (!jettyExcludeURL.isEmpty()) {
this.jettyExcludeUrlFilter = new ExcludeUrlFilter(jettyExcludeURL);
}
else{
this.jettyExcludeUrlFilter = new SkipFilter<String>();
}
}
is this still not using the field I've added above?
There was a problem hiding this comment.
No, it's not using ProfilerConfig.jettyExcludeUrlFilter. Among members of ProfilerConfig, JettyConfiguration only uses readString(), which is not accessing jettyExcludedUrlFilter.
There was a problem hiding this comment.
Right. Got jettyExcludeUrlFilter and jettyExcludeURL confused. Thank you!
|
@lioolli |
|
👍 |
This is a Jetty plugin that supports synchronous requests. #446
I've added my notes on the plugin in the wiki if anyone wants to take a look.