Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[#8952] Replace guava cache with caffeine cache #8953

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jun 21, 2022

No description provided.

@emeroad emeroad linked an issue Jun 21, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #8953 (1c89a16) into master (cdabbee) will increase coverage by 0.00%.
The diff coverage is 71.69%.

@@            Coverage Diff            @@
##             master    #8953   +/-   ##
=========================================
  Coverage     39.80%   39.81%           
- Complexity    11828    11835    +7     
=========================================
  Files          3350     3351    +1     
  Lines         91074    91079    +5     
  Branches      10083    10084    +1     
=========================================
+ Hits          36256    36267   +11     
+ Misses        51717    51716    -1     
+ Partials       3101     3096    -5     
Impacted Files Coverage Δ
...p/pinpoint/bootstrap/classloader/ProfilerLibs.java 75.00% <ø> (ø)
...avercorp/pinpoint/test/MockApiMetaDataService.java 0.00% <0.00%> (ø)
.../com/navercorp/pinpoint/profiler/cache/Result.java 100.00% <ø> (ø)
.../provider/metadata/ApiMetaDataServiceProvider.java 100.00% <ø> (ø)
.../provider/metadata/SqlMetadataServiceProvider.java 100.00% <ø> (ø)
...ovider/metadata/StringMetadataServiceProvider.java 100.00% <ø> (ø)
...t/profiler/metadata/DefaultApiMetaDataService.java 100.00% <ø> (ø)
...profiler/metadata/DefaultCachingSqlNormalizer.java 56.66% <ø> (ø)
...t/profiler/metadata/DefaultSqlMetaDataService.java 76.47% <ø> (ø)
...rofiler/metadata/DefaultStringMetaDataService.java 81.81% <ø> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdabbee...1c89a16. Read the comment docs.

@emeroad emeroad force-pushed the #8952_cache_migration branch 3 times, most recently from e40881a to 466afbd Compare June 22, 2022 02:49
@emeroad emeroad force-pushed the #8952_cache_migration branch from 466afbd to 1c89a16 Compare June 23, 2022 02:05
@emeroad emeroad merged commit 4c42e52 into pinpoint-apm:master Jun 23, 2022
@emeroad emeroad deleted the #8952_cache_migration branch June 23, 2022 02:32
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace guava cache with caffeine cache
1 participant