Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[#9000] Use insertRuleExceptWebhookSend when webhook.enable=false #9001

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

ga-ram
Copy link
Contributor

@ga-ram ga-ram commented Jun 30, 2022

No description provided.

@ga-ram ga-ram linked an issue Jun 30, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #9001 (62e2097) into master (cad01c8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #9001      +/-   ##
============================================
- Coverage     39.76%   39.75%   -0.02%     
+ Complexity    11791    11790       -1     
============================================
  Files          3346     3346              
  Lines         90805    90805              
  Branches      10053    10053              
============================================
- Hits          36111    36098      -13     
- Misses        51603    51611       +8     
- Partials       3091     3096       +5     
Impacted Files Coverage Δ
...vercorp/pinpoint/web/service/AlarmServiceImpl.java 0.00% <0.00%> (ø)
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...pc/server/LoggingServerMessageListenerFactory.java 80.95% <0.00%> (-9.53%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...ollector/cluster/zookeeper/ZookeeperJobWorker.java 76.47% <0.00%> (-1.61%) ⬇️
...corp/pinpoint/rpc/stream/StreamChannelManager.java 60.67% <0.00%> (-1.13%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 81.06% <0.00%> (-0.83%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 75.92% <0.00%> (+3.70%) ⬆️
...p/pinpoint/rpc/stream/StreamChannelRepository.java 78.94% <0.00%> (+21.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad01c8...62e2097. Read the comment docs.

@ga-ram ga-ram merged commit 3ff6559 into pinpoint-apm:master Jul 1, 2022
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column webhook_send is still used when webhook.enable property is false
2 participants