Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[#9573] Refactor TagParser to TagUtils, Apply regex precompile #9600

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

donghun-cho
Copy link
Contributor

@donghun-cho donghun-cho commented Jan 4, 2023

  • TagParser renamed
  • change non-static method to static method
  • Apply pre-compile regex pattern

@donghun-cho donghun-cho added this to the 2.5.1 milestone Jan 4, 2023
@donghun-cho donghun-cho self-assigned this Jan 4, 2023
@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #9600 (fa29637) into master (4c41304) will increase coverage by 0.02%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #9600      +/-   ##
============================================
+ Coverage     38.86%   38.89%   +0.02%     
- Complexity    11890    11906      +16     
============================================
  Files          3491     3491              
  Lines         93811    93811              
  Branches      10535    10535              
============================================
+ Hits          36460    36485      +25     
+ Misses        54190    54161      -29     
- Partials       3161     3165       +4     
Impacted Files Coverage Δ
.../metric/web/controller/SystemMetricController.java 0.00% <0.00%> (ø)
...ic/web/dao/pinot/PinotSystemMetricHostInfoDao.java 0.00% <0.00%> (ø)
...ic/web/mybatis/typehandler/TagListTypeHandler.java 0.00% <0.00%> (ø)
...metric/web/mybatis/typehandler/TagTypeHandler.java 0.00% <0.00%> (ø)
...etric/web/service/SystemMetricDataServiceImpl.java 0.00% <0.00%> (ø)
...m/navercorp/pinpoint/metric/web/util/TagUtils.java 82.14% <66.66%> (ø)
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...m/navercorp/pinpoint/rpc/client/ConnectFuture.java 70.83% <0.00%> (-8.34%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...tor/metric/datasource/DefaultDataSourceMetric.java 85.18% <0.00%> (-3.71%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@donghun-cho donghun-cho linked an issue Jan 5, 2023 that may be closed by this pull request
@donghun-cho donghun-cho changed the title [#9573] Apply Regex precompile to TagParser, Change non-static method… [#9573] Refactor TagParser to TagUtils, Apply regex precompile Jan 6, 2023
@donghun-cho donghun-cho merged commit 708a117 into pinpoint-apm:master Jan 6, 2023
@donghun-cho donghun-cho deleted the regex_precompile branch January 9, 2023 01:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply Regex precompile to TagParser
1 participant