Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[#9601] Fix tests aarch64 compatible #9602

Merged
merged 1 commit into from
Jan 6, 2023
Merged

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Jan 4, 2023

resolves #9601

Changes

  • Split grpc tests into two parts, one of them does not compile .proto file, but use pre-compiled java source.
  • normalize path of temporary directory on AgentDirBaseClassPathResolverTest
  • Ignore JtdsConnectionIT, mariadb-tests, oracledb-tests if aarch64-docker-server is installed on host
  • Stabilized random failure on CoroutineIT
  • Bump testcontainers to 1.17.2 -> 1.17.6, replaced hard-coded old testcontainers version.
  • Replaced deprecated SocketUtils.findAvailablePorts
  • Ignore non-reachable local v4 IP

@codecov
Copy link

codecov bot commented Jan 4, 2023

Codecov Report

Merging #9602 (ab1d304) into master (0f27aa2) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9602      +/-   ##
============================================
- Coverage     38.87%   38.87%   -0.01%     
+ Complexity    11885    11884       -1     
============================================
  Files          3486     3486              
  Lines         93748    93747       -1     
  Branches      10522    10524       +2     
============================================
- Hits          36446    36440       -6     
  Misses        54144    54144              
- Partials       3158     3163       +5     
Impacted Files Coverage Δ
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...m/navercorp/pinpoint/rpc/client/ConnectFuture.java 70.83% <0.00%> (-8.34%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 68.51% <0.00%> (-3.71%) ⬇️
...tor/metric/datasource/DefaultDataSourceMetric.java 85.18% <0.00%> (-3.71%) ⬇️
...avercorp/pinpoint/bootstrap/util/NetworkUtils.java 43.61% <0.00%> (-2.70%) ⬇️
...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java 51.66% <0.00%> (-1.67%) ⬇️
...pinpoint/profiler/monitor/DeadlockMonitorTask.java 20.45% <0.00%> (-1.14%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 81.06% <0.00%> (+1.23%) ⬆️
...ollector/cluster/zookeeper/ZookeeperJobWorker.java 77.54% <0.00%> (+1.60%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@smilu97 smilu97 merged commit 291d3dd into pinpoint-apm:master Jan 6, 2023
@smilu97 smilu97 deleted the 9601_test branch January 6, 2023 03:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some tests doesn't work properly on aarch64 JVM
1 participant