Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[#noissue] Apply ConditionalOnProperty to InstallModule #9884

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Apr 20, 2023

No description provided.

@emeroad emeroad added this to the 2.6.0 milestone Apr 20, 2023
@emeroad emeroad force-pushed the #noissue_installmodule branch from d82bc47 to bd2a24e Compare April 20, 2023 05:59
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #9884 (d82bc47) into master (00299d3) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head d82bc47 differs from pull request most recent head bd2a24e. Consider uploading reports for the commit bd2a24e to get more accurate results

@@             Coverage Diff              @@
##             master    #9884      +/-   ##
============================================
- Coverage     38.79%   38.79%   -0.01%     
  Complexity    11911    11911              
============================================
  Files          3539     3539              
  Lines         94181    94180       -1     
  Branches      10495    10495              
============================================
- Hits          36534    36533       -1     
- Misses        54472    54474       +2     
+ Partials       3175     3173       -2     
Impacted Files Coverage Δ
.../navercorp/pinpoint/web/install/InstallModule.java 100.00% <100.00%> (+100.00%) ⬆️
...nt/web/install/dao/GithubAgentDownloadInfoDao.java 35.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emeroad emeroad merged commit 99deca7 into pinpoint-apm:master Apr 20, 2023
@emeroad emeroad deleted the #noissue_installmodule branch April 20, 2023 08:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant