Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[#9876] Unified naming convention #9891

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Apr 21, 2023

Fixed flink not able to start-up because of bean name mismatching problem

Bootstrap.java

flinkConfiguration = applicationContext.getBean("flinkConfiguration", FlinkConfiguration.class);
<bean id="flinkProperties" class="com.navercorp.pinpoint.flink.config.FlinkConfiguration"/>

@smilu97 smilu97 requested a review from emeroad April 21, 2023 08:53
@smilu97 smilu97 self-assigned this Apr 21, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #9891 (e60035a) into master (5d2e5f6) will increase coverage by 0.00%.
The diff coverage is 15.38%.

@@            Coverage Diff            @@
##             master    #9891   +/-   ##
=========================================
  Coverage     38.79%   38.79%           
- Complexity    11908    11910    +2     
=========================================
  Files          3538     3538           
  Lines         94167    94168    +1     
  Branches      10495    10495           
=========================================
+ Hits          36533    36534    +1     
- Misses        54459    54461    +2     
+ Partials       3175     3173    -2     
Impacted Files Coverage Δ
...n/java/com/navercorp/pinpoint/flink/Bootstrap.java 0.00% <0.00%> (ø)
...rp/pinpoint/flink/cluster/FlinkServerRegister.java 0.00% <0.00%> (ø)
...vercorp/pinpoint/flink/config/FlinkProperties.java 36.36% <100.00%> (ø)

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@smilu97 smilu97 merged commit a8de915 into pinpoint-apm:master Apr 24, 2023
@smilu97 smilu97 deleted the 9876_unc branch April 24, 2023 02:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant