Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[#noissue] Refactor grpc ssl initialization #9899

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Apr 25, 2023

No description provided.

@emeroad emeroad added this to the 2.6.0 milestone Apr 25, 2023
@emeroad emeroad force-pushed the #noissue_grpc_ssl branch from 97b8104 to 2c887aa Compare April 25, 2023 08:49
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #9899 (2c887aa) into master (32c0b6d) will decrease coverage by 0.02%.
The diff coverage is 7.84%.

@@             Coverage Diff              @@
##             master    #9899      +/-   ##
============================================
- Coverage     38.78%   38.77%   -0.02%     
+ Complexity    11911    11906       -5     
============================================
  Files          3538     3538              
  Lines         94190    94181       -9     
  Branches      10498    10496       -2     
============================================
- Hits          36531    36516      -15     
- Misses        54488    54494       +6     
  Partials       3171     3171              
Impacted Files Coverage Δ
...oint/grpc/client/DefaultChannelFactoryBuilder.java 70.37% <0.00%> (+7.87%) ⬆️
...corp/pinpoint/grpc/security/SslContextFactory.java 0.00% <0.00%> (ø)
...p/pinpoint/profiler/context/module/GrpcModule.java 0.00% <0.00%> (ø)
...ext/provider/grpc/AgentGrpcDataSenderProvider.java 0.00% <0.00%> (ø)
.../provider/grpc/MetadataGrpcDataSenderProvider.java 0.00% <0.00%> (ø)
...iler/context/provider/grpc/SSLContextProvider.java 0.00% <0.00%> (ø)
...text/provider/grpc/SpanGrpcDataSenderProvider.java 0.00% <0.00%> (ø)
...text/provider/grpc/StatGrpcDataSenderProvider.java 0.00% <0.00%> (ø)
...rp/pinpoint/grpc/client/DefaultChannelFactory.java 75.25% <60.00%> (+3.41%) ⬆️
...filer/context/grpc/config/GrpcTransportConfig.java 58.57% <100.00%> (-0.30%) ⬇️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@emeroad emeroad merged commit cec5c0a into pinpoint-apm:master Apr 25, 2023
@emeroad emeroad deleted the #noissue_grpc_ssl branch April 25, 2023 09:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant